Skip to content

Conversation

@dlmarion
Copy link
Contributor

Removed 2.x and 3.x properties from the docs-4 directory, added updated property and metrics files generated with apache/accumulo#5495

@dlmarion dlmarion requested a review from DomGarguilo April 22, 2025 21:38
@dlmarion dlmarion self-assigned this Apr 22, 2025
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be generated files, and it's draft docs. Probably don't need to do a PR for these. But, I did notice you changed the filenames, and that doesn't correspond to what the build generates (at least, not yet)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build hard-codes the generated filename as server-properties3.md right now. The build would need to be updated if we're going to go with a different name. This was only changed to add the number for the old docs, because version 2 and 3 were put in the same place. It looks like this won't be the case, given that you've copied all the docs to a different path. So, could go back to the filename without the number on the end.

This same comment applies to the generated metrics and client-properties docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my comments... I see the linked PR to the main branch now. Just merge them both.

@dlmarion dlmarion merged commit 6c44ced into apache:main Apr 23, 2025
1 check passed
@dlmarion dlmarion deleted the 4.x-properties branch April 23, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants