Skip to content

Improve development dockerfile and associated readme #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ctubbsii merged 2 commits into from
May 8, 2025
Merged

Improve development dockerfile and associated readme #460

ctubbsii merged 2 commits into from
May 8, 2025

Conversation

@DomGarguilo
Copy link
Member

@DomGarguilo DomGarguilo commented Apr 30, 2025

  • breaks some commands into individual lines to make future maintenance less disruptive
  • use uppercase AS in dockerfile. There was a warning regarding inconsistent case
  • improve readme with a pitfall that I ran into
  • remove duplicate line from readme and empty lines

@DomGarguilo DomGarguilo requested a review from ddanielr April 30, 2025 21:05
@DomGarguilo DomGarguilo self-assigned this Apr 30, 2025
ctubbsii
ctubbsii reviewed Apr 30, 2025
View reviewed changes
@ctubbsii ctubbsii merged commit bdcd057 into apache:main May 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

@ddanielr ddanielr Awaiting requested review from ddanielr

Assignees

@DomGarguilo DomGarguilo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DomGarguilo @ctubbsii