Skip to content

Add TimestampWithOffset canonical extension type #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serramatutu wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add TimestampWithOffset canonical extension type #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5dfba71
Add `TimestampWithOffset` extension type
serramatutu Oct 28, 2025
df33327
Allow dictionary encoding of `TimestampWithOffset`
serramatutu Dec 22, 2025
7d023b6
Allow run-end encoding of `TimestampWithOffset`
serramatutu Dec 22, 2025
9980eb2
Optimize `Values()` and `MarshalJSON()` for REE
serramatutu Dec 22, 2025
bd12287
General code smell patches
serramatutu Jan 30, 2026
cee17a3
Test with `-08:30` and `11:00` timezone
serramatutu Jan 30, 2026
e36a78f
Rename constructors
serramatutu Jan 30, 2026
cbf8f65
Leverage generics for REE and dict-encoding
serramatutu Feb 2, 2026
eff57e6
Add `UnsafeAppendBoolToBitmap()` to dict and REE builders
serramatutu Feb 3, 2026
2762d64
Make equals also check for data type
serramatutu Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions arrow/array/dictionary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,12 @@ func (b *dictionaryBuilder) Release() {
}
}

func (b *dictionaryBuilder) UnsafeAppendBoolToBitmap(v bool) {
b.length += 1
b.nulls += 1
b.idxBuilder.UnsafeAppendBoolToBitmap(v)
}

func (b *dictionaryBuilder) AppendNull() {
b.length += 1
b.nulls += 1
Expand Down
9 changes: 9 additions & 0 deletions arrow/array/encoded.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,15 @@ func (b *RunEndEncodedBuilder) ContinueRun(n uint64) {
b.addLength(n)
}

func (b *RunEndEncodedBuilder) UnsafeAppendBoolToBitmap(v bool) {
if !v {
b.finishRun()
}
Comment on lines +390 to +392
Copy link
Member

@zeroshade zeroshade Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems incorrect, it could be a run of nulls, couldn't it? And wouldn't the run itself be handled by the value append? I don't think we need to call b.finishRun here


b.values.UnsafeAppendBoolToBitmap(v)
b.addLength(1)
}

func (b *RunEndEncodedBuilder) AppendNull() {
b.finishRun()
b.values.AppendNull()
Expand Down
7 changes: 4 additions & 3 deletions arrow/extensions/extensions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ import (
)

var canonicalExtensionTypes = []arrow.ExtensionType{
NewBool8Type(),
NewUUIDType(),
&OpaqueType{},
&JSONType{},
&OpaqueType{},
&TimestampWithOffsetType{},
&VariantType{},
NewBool8Type(),
NewUUIDType(),
}

func init() {
Expand Down
Loading
Loading