Remove lint issues in parquet-related code. #9375
Open
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunal
force-pushed
the
main
branch
2 times, most recently
from
2bb71a6 to
efe310e
Compare
* CacheOptions: `use` in arrow/push_decoder/reader_builder/mod.rs was unused. But removing it triggers a doc complaint in array_reader.rs. I fix it by spelling out `CacheOptions` at one usage site. * ExtensionType import was unused in arrow/schema/extension.rs when compiling with default features. Only `use` it inside the feature-guarded code paths. * Prefix unused function arguments with `_`. * Some code in parquet/tests/arrow_reader/io/mod.rs is unused. As I lack knowledge of the context, I just add just add #[allow(dead_code)].
Jefffrey
reviewed
Feb 10, 2026
Comment on lines
21
to
25
| //! Arrow [`arrow_schema::extension::ExtensionType`]s. | ||
| //! | ||
| //! Extension types are represented using the metadata from Arrow [`Field`]s | ||
| //! with the key "ARROW:extension:name". | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| //! Arrow [`ExtensionType`]s. | |
| //! | |
| //! Extension types are represented using the metadata from Arrow [`Field`]s | |
| //! with the key "ARROW:extension:name". | |
| //! | |
| //! [`ExtensionType`]: arrow_schema::extension::ExtensionType | |
Maybe we can do it like this to keep it clean
| ops: Arc<OperationLog>, | ||
| /// The (pre-parsed) parquet metadata for this file | ||
| // TODO: this is unused; consider removing it. | ||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
Maybe for this dead code we can use it in a test somewhere to assert something useful? 🤔
| match parquet_logical_type { | ||
| #[cfg(feature = "variant_experimental")] | ||
| LogicalType::Variant { .. } => { | ||
| arrow_field.try_with_extension_type(parquet_variant_compute::VariantType)?; |
Contributor
There was a problem hiding this comment.
Maybe we could rebind in each of these arms like so?
let mut arrow_field = arrow_field;I usually prefer to use expect instead of allow but we'd need to cfg it with three different features here, so maybe its easier to just narrow the mut scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheOptions:
usein arrow/push_decoder/reader_builder/mod.rs wasunused. But removing it triggers a doc complaint in array_reader.rs.
I fix it by spelling out
CacheOptionsat one usage site.ExtensionType import was unused in arrow/schema/extension.rs when
compiling with default features. Only
useit inside thefeature-guarded code paths.
Prefix unused function arguments with
_.Some code in parquet/tests/arrow_reader/io/mod.rs is unused. As I lack
knowledge of the context, I just add just add #[allow(dead_code)].
Rationale for this change
rust-analyzer bugs me about those unused symbols & co.