Minor: Add additional test coverage for WriterProperties::{max_row_group_row_count,max_row_group_size} #9387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up_row_count,max_row_group_size}
alamb
commented
Feb 10, 2026
| assert_eq!(total_rows, 100, "Total rows should be preserved"); | ||
| } | ||
|
|
||
| #[test] |
Contributor
Author
There was a problem hiding this comment.
If you run code coverage like this
cargo llvm-cov --html -p parquet --features=arrow,asyncYou'll see there are a few missing lines in parquet/src/arrow/arrow_writer/mod.rs.html
Specifically:
This test covers that branch
alamb
changed the title
etseidl
approved these changes
Feb 10, 2026
yonipeleg33
approved these changes
Feb 11, 2026
Contributor
yonipeleg33
left a comment
yonipeleg33
left a comment
There was a problem hiding this comment.
Thanks, great stuff!
Contributor
Author
|
Thanks @etseidl and @yonipeleg33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing this PR, I found (with codex) some additional code paths that I think would be valuable to test:
Some(0)for the max sizesWhat changes are included in this PR?
Add tets
Are these changes tested?
Are there any user-facing changes?