Skip to content

[CELEBORN-2240] Adapt to SPARK-51756 which add a new parameter checksumValue in MapStatus.apply #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 1 commit into from
+9 −1
Closed

[CELEBORN-2240] Adapt to SPARK-51756 which add a new parameter checksumValue in MapStatus.apply #3570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,17 @@ public class SparkUtils {
public static final String FETCH_FAILURE_ERROR_MSG =
"Celeborn FetchFailure appShuffleId/shuffleId: ";

private static final DynMethods.BoundMethod MAP_STATUS_APPLY_METHOD =
DynMethods.builder("apply")
// for SPARK-51756 (4.1.0) and later
Copy link
Member

@turboFei turboFei Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apache/spark#50230

SPARK-54663 or SPARK-51756

Copy link
Member

@turboFei turboFei Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about add the PR title as well, the new field is checksumValue.

Copy link
Member Author

@pan3793 pan3793 Dec 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seems the author changes the JIRA ticket in the PR title after merging -

  • the git commit history is SPARK-51756
  • the final PR title is changed to SPARK-54663

not a big deal, since SPARK-54663 is a sub-task of SPARK-51756.

.impl(MapStatus$.class, BlockManagerId.class, long[].class, long.class, long.class)
// for Spark 4.0 and earlier
.impl(MapStatus$.class, BlockManagerId.class, long[].class, long.class)
.build(MapStatus$.MODULE$);

public static MapStatus createMapStatus(
BlockManagerId loc, long[] uncompressedSizes, long mapTaskId) {
return MapStatus$.MODULE$.apply(loc, uncompressedSizes, mapTaskId);
return MAP_STATUS_APPLY_METHOD.invoke(loc, uncompressedSizes, mapTaskId, 0L);
}

private static final DynFields.UnboundField<SQLMetric> DATA_SIZE_METRIC_FIELD =
Expand Down
Loading