Skip to content

upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail) - #37

Closed
gitmotte wants to merge 7 commits into
apache:masterfrom
gitmotte:master
Closed

upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail)#37
gitmotte wants to merge 7 commits into
apache:masterfrom
gitmotte:master

Conversation

@gitmotte

@gitmotte gitmotte commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

* package rename javax.mail -> jakarta.mail
@gitmotte gitmotte changed the title upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail) wip: upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail) Jan 19, 2021
@gitmotte gitmotte changed the title wip: upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail) upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail) Mar 1, 2021
@KroArtem

KroArtem commented Jun 8, 2022

Copy link
Copy Markdown

@garydgregory , hello, do you accidentally know why this PR was not merged? Current 1.x commons-email uses old javax.mail and it's hard to switch to jakarta.mail as one lib (e.g. subethamail) depends on another and so on. I see that in e0cf5b6 you've updated jakarta.mail but I assume those changes were never released.

@garydgregory

Copy link
Copy Markdown
Member
  1. the build fails and 2) we are all volunteers here.

@garydgregory

garydgregory commented Jun 8, 2022

Copy link
Copy Markdown
Member

I'll update the GH build to only use LTS versions...

@garydgregory

Copy link
Copy Markdown
Member

Hm, looks like this branch needs a rebase.

@KroArtem

KroArtem commented Jun 8, 2022

Copy link
Copy Markdown

the build fails and 2) we are all volunteers here.

Sure, no pressure here, just wanted to know whether there was an objective reason not to merge it.

As I see the situation, it's a breaking change and major version update is required.

@KroArtem KroArtem mentioned this pull request Jun 8, 2022
@garydgregory

Copy link
Copy Markdown
Member

@gitmotte
This PR needs a rebase so we can see what all the various checks say.

@KroArtem

Copy link
Copy Markdown

Based on discussions in my PR (linked above) this PR needs to be closed...

@Loki-Afro

Copy link
Copy Markdown
Contributor

looking forward to this one, unfortunately the logs for the failing builds are not available anymore

@reda-alaoui

Copy link
Copy Markdown
Member

To anybody interested, I created #133 as a replacement for this PR.

@garydgregory

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants