Skip to content

Enhance InfosetNoDataException message to include circular dependencies #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olabusayoT merged 1 commit into from
Feb 16, 2026
+135 −1
Merged

Enhance InfosetNoDataException message to include circular dependencies #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion daffodil-core/src/main/scala/org/apache/daffodil/runtime1/infoset/InfosetImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,12 @@ sealed abstract class InfosetNoDataExceptionBase(
case class InfosetNoDataException(
override val diElement: DIElement,
override val erd: ElementRuntimeData
) extends InfosetNoDataExceptionBase(diElement, erd, "Element does not have a value.")
) extends InfosetNoDataExceptionBase(
diElement,
erd,
"Element does not have a value. " +
"This may indicate a circular dependency in the schema."
)

case class InfosetSelfReferencingException(
override val diElement: DIElement,
Expand Down
123 changes: 123 additions & 0 deletions ...il-test/src/test/resources/org/apache/daffodil/section00/general/testUnparserGeneral.tdml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,4 +994,127 @@
<tdml:document>a</tdml:document>
</tdml:unparserTestCase>

<tdml:defineSchema name="truncatedString1">
<xs:include schemaLocation="/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd" />

<dfdl:format ref="ex:GeneralFormat" encoding="ascii"
lengthUnits="bytes"/>

<xs:element name="e1">
<xs:complexType>
<xs:sequence>
<xs:element name="len" type="xs:int" dfdl:lengthKind="explicit" dfdl:length="1"
dfdl:outputValueCalc="{ if (dfdl:valueLength(../ex:data , 'bytes') gt 5) then 5 else dfdl:valueLength(../ex:data , 'bytes') }" />
<xs:element name="data" type="xs:string" dfdl:lengthKind='explicit'
dfdl:length='{../ex:len}' dfdl:truncateSpecifiedLengthString='yes'/>
</xs:sequence>
</xs:complexType>
</xs:element>

</tdml:defineSchema>

<tdml:unparserTestCase name="truncatedString_1" root="e1" model="truncatedString1">
<tdml:infoset>
<tdml:dfdlInfoset>
<ex:e1>
<ex:len>0</ex:len>
<ex:data>ABCDEFG</ex:data>
</ex:e1>
</tdml:dfdlInfoset>
</tdml:infoset>
<tdml:errors>
<tdml:error>not have a value</tdml:error>
<tdml:error>circular dependency</tdml:error>
</tdml:errors>
</tdml:unparserTestCase>

<tdml:defineSchema name="truncatedString2">
<xs:include schemaLocation="/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd" />

<dfdl:format ref="ex:GeneralFormat" encoding="ascii"
lengthUnits="bytes"/>

<xs:element name="e1">
<xs:complexType>
<xs:sequence>
<xs:element name="len" type="xs:int" dfdl:lengthKind="explicit" dfdl:length="1"
dfdl:outputValueCalc="{ if (fn:string-length(../ex:data) gt 5) then 5 else fn:string-length(../ex:data) }" />
<xs:element name="data" type="xs:string" dfdl:lengthKind='explicit'
dfdl:length='{../ex:len}' dfdl:truncateSpecifiedLengthString='yes'/>
</xs:sequence>
</xs:complexType>
</xs:element>
</tdml:defineSchema>

<tdml:unparserTestCase name="truncatedString_2" root="e1" model="truncatedString2">
<tdml:infoset>
<tdml:dfdlInfoset>
<ex:e1>
<ex:len>0</ex:len>
<ex:data>ABCDEFG</ex:data>
</ex:e1>
</tdml:dfdlInfoset>
</tdml:infoset>
<tdml:errors>
<tdml:error>not have a value</tdml:error>
<tdml:error>circular dependency</tdml:error>
</tdml:errors>
</tdml:unparserTestCase>

<tdml:defineSchema name="truncatedString3">
<xs:include schemaLocation="/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd" />

<dfdl:format ref="ex:GeneralFormat" encoding="ascii"
lengthUnits="bytes"/>

<xs:element name="e1">
<xs:complexType>
<xs:sequence>
<xs:element name="data" type="xs:string" dfdl:lengthKind='explicit'
dfdl:length='{ if (fn:string-length(.) gt 5) then 5 else fn:string-length(.) }' dfdl:truncateSpecifiedLengthString='yes'/>
</xs:sequence>
</xs:complexType>
</xs:element>
</tdml:defineSchema>

<tdml:unparserTestCase name="truncatedString_3" root="e1" model="truncatedString3">
<tdml:infoset>
<tdml:dfdlInfoset>
<ex:e1>
<ex:data>ABCDEFG</ex:data>
</ex:e1>
</tdml:dfdlInfoset>
</tdml:infoset>
<tdml:document>ABCDE</tdml:document>
</tdml:unparserTestCase>

<tdml:defineSchema name="truncatedString4">
<xs:include schemaLocation="/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd" />

<dfdl:format ref="ex:GeneralFormat" encoding="ascii"
lengthUnits="bytes"/>

<xs:element name="e1">
<xs:complexType>
<xs:sequence>
<xs:element name="data" type="xs:string" dfdl:lengthKind='explicit'
dfdl:length="{ if (dfdl:valueLength(. , 'bytes') gt 5) then 5 else dfdl:valueLength(. , 'bytes') }" dfdl:truncateSpecifiedLengthString='yes'/>
</xs:sequence>
</xs:complexType>
</xs:element>
</tdml:defineSchema>

<tdml:unparserTestCase name="truncatedString_4" root="e1" model="truncatedString4">
<tdml:infoset>
<tdml:dfdlInfoset>
<ex:e1>
<ex:data>ABCDEFG</ex:data>
</ex:e1>
</tdml:dfdlInfoset>
</tdml:infoset>
<tdml:errors>
<tdml:error>Value length unknown</tdml:error>
</tdml:errors>
</tdml:unparserTestCase>

</tdml:testSuite>
6 changes: 6 additions & 0 deletions daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestUnparserGeneral.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,10 @@ class TestUnparserGeneral extends TdmlTests {
@Test def emptyOutputNewLine1 = test

@Test def unparseIgnorableContent = test

// DFDL-1598
@Test def truncatedString_1 = test
@Test def truncatedString_2 = test
@Test def truncatedString_3 = test
@Test def truncatedString_4 = test
}