Repository navigation
feat: configure Iceberg reader concurrency and pruning - #126
Draft
alexanderbianchi wants to merge 1 commit into
Draft
alexanderbianchi wants to merge 1 commit into
alexanderbianchi wants to merge 1 commit into
Conversation
Signed-off-by: alex.bianchi <alex.bianchi@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an interim session-to-reader mapping using the current iceberg-rust pin, based on the reader controls in DFD #595 / #720.
iceberg.execution.data_file_concurrency_limitper output partition. Preserve the current default of one and normalize zero to one, matching iceberg-rust #3514.datafusion.execution.parquet.pruningfor reader row-group filtering.with_reader(...)overrides continue to take precedence.Once the dependency includes iceberg-rust #3514, replace the private setter mapping with
ArrowReaderOptionsandwith_options(...). The session configuration can remain the same across that update.Tests use the existing SQL harness: disabling row-group pruning increases data reads without changing results, and zero concurrency still completes a scan. Confirmed the tests fail when the pruning mapping and zero normalization are removed. Existing batch-size and page-index tests remain in place.
Validation:
cargo test --workspace --lockedcargo clippy --workspace --locked --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkDeveloped with AI assistance.