Skip to content

refactor!: return only the provider from FileScanTaskProviderBuilder - #129

Merged
gabotechs merged 1 commit into
apache:mainfrom
alexanderbianchi:fix/task-provider-builder
Nov 20, 2026
Merged

gabotechs merged 1 commit into
apache:mainfrom
alexanderbianchi:fix/task-provider-builder

Conversation

@alexanderbianchi

Copy link
Copy Markdown
Contributor

Addresses the follow-up review comment on #113.

The catalog and static table providers now project their advertised schema once and pass it to both builders. FileScanTaskProviderBuilder::build() returns only the provider in both lazy and eager mode.

Verified: workspace tests, formatting, and Clippy with warnings denied.

@gabotechs gabotechs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice

@gabotechs
gabotechs merged commit 865c081 into apache:main Nov 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants