Skip to content

[CH][VL] Move DateFormatter and TimestampFormatter creation out of partition value loops #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FelixYBW merged 2 commits into from
Apr 9, 2026
Merged

[CH][VL] Move DateFormatter and TimestampFormatter creation out of partition value loops #11843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e395e2e
Use single formatter instance across all files
acvictor Mar 27, 2026
3c2bdd3
Merge branch 'main' into acvictor/formatter
acvictor Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ds-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ class CHIteratorApi extends IteratorApi with Logging with LogLevelUtil {
val partitionColumns = new JArrayList[JMap[String, String]]
val metadataColumns = new JArrayList[JMap[String, String]]
val otherMetadataColumns = new JArrayList[JMap[String, Object]]
val dateFormatter = DateFormatter()
val timestampFormatter = TimestampFormatter.getFractionFormatter(ZoneOffset.UTC)
f.files.foreach {
file =>
paths.add(new URI(file.filePath.toString()).toASCIIString)
Expand All @@ -183,13 +185,11 @@ class CHIteratorApi extends IteratorApi with Logging with LogLevelUtil {
case _: BinaryType =>
new String(pn.asInstanceOf[Array[Byte]], StandardCharsets.UTF_8)
case _: DateType =>
DateFormatter.apply().format(pn.asInstanceOf[Integer])
dateFormatter.format(pn.asInstanceOf[Integer])
case _: DecimalType =>
pn.asInstanceOf[Decimal].toJavaBigInteger.toString
case _: TimestampType =>
TimestampFormatter
.getFractionFormatter(ZoneOffset.UTC)
.format(pn.asInstanceOf[java.lang.Long])
timestampFormatter.format(pn.asInstanceOf[java.lang.Long])
case _ => pn.toString
}
}
Expand Down
8 changes: 4 additions & 4 deletions backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ class VeloxIteratorApi extends IteratorApi with Logging {
private def getPartitionColumns(
schema: StructType,
partitionedFiles: Seq[PartitionedFile]): Seq[Map[String, String]] = {
val dateFormatter = DateFormatter()
val timestampFormatter = TimestampFormatter.getFractionFormatter(ZoneOffset.UTC)
partitionedFiles.map {
partitionedFile =>
val partitionColumn = mutable.Map[String, String]()
Expand All @@ -159,13 +161,11 @@ class VeloxIteratorApi extends IteratorApi with Logging {
case _: BinaryType =>
new String(pv.asInstanceOf[Array[Byte]], StandardCharsets.UTF_8)
case _: DateType =>
DateFormatter.apply().format(pv.asInstanceOf[Integer])
dateFormatter.format(pv.asInstanceOf[Integer])
case _: DecimalType =>
pv.asInstanceOf[Decimal].toJavaBigDecimal.unscaledValue().toString
case _: TimestampType =>
TimestampFormatter
.getFractionFormatter(ZoneOffset.UTC)
.format(pv.asInstanceOf[java.lang.Long])
timestampFormatter.format(pv.asInstanceOf[java.lang.Long])
case _ => pv.toString
}
}
Expand Down
Loading