Skip to content

Various Unit Test Fixes #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skrawcz wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Various Unit Test Fixes #1429

skrawcz wants to merge 16 commits into from

Conversation

@skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 29, 2025 •
edited
Loading

Because we have so many integrations, our unit tests can fail because the world moved.

We only care about having unit tests work against the latest version of a library -- though we need to
ensure we're backwards compatible with older versions if we want to ensure we wont break anyone.

Changes

  • updates due to some deprecation warnings
  • fixes for unit tests -- see commits
  • adds more license headers
  • punts on one or two tests

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz skrawcz force-pushed the stefan/fix-unit-tests branch from e19b543 to 9163f73 Compare December 29, 2025 11:46
@skrawcz
Fix hamilton-lsp
83761b4 
pygls changed it’s import structure — so handle that.
@skrawcz
Update AST check due to deprecation
6bd85f0
@skrawcz
Updates UTC use
0ef947e 
Updating code to not use the deprecated way of getting UTC time.
@skrawcz
Fixes hugging face test
53e18cc 
This changes things so that the we compare things
in an order invariant way, but also handles the newer
hugging face library change.
@skrawcz
Updates pydantic model use to use model_dump
243f3f5 
This removes use of the deprecated way to dump
a pydantic model.
@skrawcz
Updates polars tests
31119f4
@skrawcz
Updates other unit tests
090d69b 
These are now the correct values.
@skrawcz
Adds more headers and updates license check files
7f22b01 
The license check should check all files, and work
against an exclusion list.

Adds missing headers to files.
@skrawcz skrawcz force-pushed the stefan/fix-unit-tests branch from 9163f73 to 7f22b01 Compare December 29, 2025 12:27
@skrawcz skrawcz force-pushed the stefan/fix-unit-tests branch from a860458 to 4dd95a1 Compare December 29, 2025 13:01
@skrawcz skrawcz requested review from cswartzvi and zilto December 29, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jernejfrank jernejfrank Awaiting requested review from jernejfrank

@elijahbenizzy elijahbenizzy Awaiting requested review from elijahbenizzy

@zilto zilto Awaiting requested review from zilto

@cswartzvi cswartzvi Awaiting requested review from cswartzvi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skrawcz