Skip to content

perf: Improve global index performance for commit time ordering #17797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihua wants to merge 1 commit into
base: master
Choose a base branch
from
+473 −1
Open

perf: Improve global index performance for commit time ordering #17797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,8 @@ public static <R> HoodieData<HoodieRecord<R>> tagGlobalLocationBackToRecords(
boolean isCommitTimeOrdered = readerContext.getMergeMode() == RecordMergeMode.COMMIT_TIME_ORDERING;
// if the index is not updating the partition of the record, and the table is COW, then we do not need to do merging at
// this phase since the writer path will merge when rewriting the files as part of the upsert operation.
boolean requiresMergingWithOlderRecordVersion = shouldUpdatePartitionPath || table.getMetaClient().getTableConfig().getTableType() == HoodieTableType.MERGE_ON_READ;
boolean requiresMergingWithOlderRecordVersion = shouldUpdatePartitionPath
|| (!isCommitTimeOrdered && table.getMetaClient().getTableConfig().getTableType() == HoodieTableType.MERGE_ON_READ);
Copy link
Copy Markdown
Contributor

@danny0405 danny0405 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch~

DeleteContext deleteContext = DeleteContext.fromRecordSchema(properties, writerSchema);

// Pair of incoming record and the global location if meant for merged lookup in later stage
Expand Down
Loading
Loading