Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions packaging/hudi-azure-bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Expand Down Expand Up @@ -77,7 +77,15 @@
<!-- Azure SDK -->
<include>com.azure:*</include>
<include>com.microsoft.azure:*</include>
<!-- Azure identity deps -->
<include>com.nimbusds:*</include>
<include>net.minidev:*</include>
<!-- Reactor -->
<include>io.projectreactor:*</include>
<include>io.projectreactor.netty:*</include>
<include>org.reactivestreams:reactive-streams</include>
<!-- Netty: bundled and shaded together with reactor-netty to avoid
version conflicts with Spark's Netty on the classpath -->
<include>io.netty:*</include>

<!-- Utils -->
Expand Down Expand Up @@ -105,6 +113,24 @@
<pattern>org.openjdk.jol.</pattern>
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
<!-- Shade Netty, Reactor, and Reactive Streams to avoid classpath
conflicts with Spark's bundled Netty -->
<relocation>
<pattern>io.netty.</pattern>
<shadedPattern>org.apache.hudi.io.netty.</shadedPattern>
</relocation>
<relocation>
<pattern>io.projectreactor.</pattern>
<shadedPattern>org.apache.hudi.io.projectreactor.</shadedPattern>
</relocation>
<relocation>
<pattern>reactor.</pattern>
<shadedPattern>org.apache.hudi.reactor.</shadedPattern>
</relocation>
<relocation>
<pattern>org.reactivestreams.</pattern>
<shadedPattern>org.apache.hudi.org.reactivestreams.</shadedPattern>
</relocation>
</relocations>
<createDependencyReducedPom>false</createDependencyReducedPom>
<filters>
Expand All @@ -116,6 +142,7 @@
<exclude>META-INF/*.RSA</exclude>
<exclude>META-INF/services/javax.*</exclude>
<exclude>**/*.proto</exclude>
<exclude>hbase-webapps/**</exclude>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nit: it might be worth adding a brief inline comment here noting which transitive dependency pulls in hbase-webapps/ — without it, a future reader will wonder why HBase UI resources are being excluded from an Azure bundle.

- AI-generated; verify before applying. React 👍/👎 to flag quality.

</excludes>
</filter>
</filters>
Expand All @@ -129,6 +156,9 @@
<resource>
<directory>src/main/resources</directory>
</resource>
<resource>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Is there a reason to add src/test/resources to the main <resources> block? Maven's standard layout already exposes it for the test phase, and adding it here will package any test resources into the production shaded jar. The sibling hudi-aws-bundle and hudi-gcp-bundle only declare src/main/resources. Could you drop this entry unless something specifically requires it?

- AI-generated; verify before applying. React 👍/👎 to flag quality.

<directory>src/test/resources</directory>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nit: including src/test/resources in the main build resources is unusual — could you add a comment explaining why it's needed here (e.g. which runtime config files live there that the bundle requires)?

- AI-generated; verify before applying. React 👍/👎 to flag quality.

</resource>
</resources>
</build>

Expand Down Expand Up @@ -174,6 +204,13 @@
<version>${parquet.version}</version>
<scope>compile</scope>
</dependency>

<!-- Avro -->
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
<version>${avro.version}</version>
<scope>compile</scope>
</dependency>
</dependencies>
</project>

Loading