fix(loader): use HTTPS download URLs in travis scripts#717
Open
fix(loader): use HTTPS download URLs in travis scripts#717
Conversation
There was a problem hiding this comment.
Pull request overview
Updates HugeGraph Loader’s Travis helper scripts to avoid insecure HTTP download URLs, aligning with the security concern raised in apache/hugegraph#2971.
Changes:
- Switch Hadoop 2.8.5 download in Travis install script from HTTP to HTTPS (
archive.apache.org). - Update the legacy (commented) MySQL download URL reference from HTTP to HTTPS.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hugegraph-loader/assembly/travis/install-hadoop.sh | Uses an HTTPS URL when downloading the Hadoop tarball. |
| hugegraph-loader/assembly/travis/install-mysql.sh | Updates the legacy commented MySQL download URL to HTTPS to avoid pointing to HTTP. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
This fixes the similar HTTP download URL issue called out for the toolchain repository in
apache/hugegraph#2971.Main Changes
hugegraph-loader/assembly/travis/install-hadoop.shto download Hadoop 2.8.5 fromhttps://archive.apache.orghugegraph-loader/assembly/travis/install-mysql.shto its HTTPS form so the script no longer points to an insecure URLVerifying these changes
bash -n hugegraph-loader/assembly/travis/install-hadoop.sh hugegraph-loader/assembly/travis/install-mysql.shcurl -I -L --max-time 20 https://archive.apache.org/dist/hadoop/common/hadoop-2.8.5/hadoop-2.8.5.tar.gzDoes this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need