Introducing FilterReferencedSnapshots helper function#720
Closed
dhananjaykrutika wants to merge 1 commit intoapache:mainfrom
Closed
Introducing FilterReferencedSnapshots helper function#720dhananjaykrutika wants to merge 1 commit intoapache:mainfrom
dhananjaykrutika wants to merge 1 commit intoapache:mainfrom
Conversation
Add FilterReferencedSnapshots() to allow catalog implementations to filter out referenced snapshot IDs from RemoveSnapshots updates before applying them during commit. This closes a race window between snapshot expiration and concurrent client commits that add refs to snapshots targeted for expiration. The filter accounts for RemoveSnapshotRef updates in the same batch, so normal expiration flows (remove ref + remove snapshot) are unaffected.
Contributor
Author
|
Abandoning in favor of #722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FilterReferencedSnapshots() to allow catalog implementations to filter out referenced snapshot IDs from RemoveSnapshots updates before applying them during commit. This closes a race window between snapshot expiration and concurrent client commits that add refs to snapshots targeted for expiration.
The filter accounts for RemoveSnapshotRef updates in the same batch, so normal expiration flows (remove ref + remove snapshot) are unaffected.