Repository navigation
[POC] refactor(writer)!: make location generators trait objects - #3738
Draft
smaheshwar-pltr wants to merge 1 commit into
Draft
smaheshwar-pltr wants to merge 1 commit into
smaheshwar-pltr wants to merge 1 commit into
Conversation
LocationGenerator no longer requires Clone, so a generator chosen at runtime can be an Arc<dyn LocationGenerator>. Writers store one instead of taking a location generator type parameter, and Table::location_generator returns the generator for the layout the table properties select. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 20, 2026
smaheshwar-pltr
commented
Nov 20, 2026
Comment on lines
+341
to
+345
| /// The layout follows | ||
| /// [`write.object-storage.enabled`](crate::spec::TableProperties::PROPERTY_WRITE_OBJECT_STORAGE_ENABLED); | ||
| /// see [`ObjectStorageLocationGenerator`](crate::writer::file_writer::location_generator::ObjectStorageLocationGenerator) | ||
| /// and [`DefaultLocationGenerator`](crate::writer::file_writer::location_generator::DefaultLocationGenerator). | ||
| /// Java's `write.location-provider.impl` is not supported and is ignored. |
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking POC of location generators being trait objects. See the changelog for details on what would break.
See smaheshwar-pltr/iceberg-rust@location-generator/dyn-trait-poc...location-generator/dyn-trait-poc-custom-providers for changes on top of this PR to support custom location providers - trait objects make that convenient.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
AI Disclosure