Repository navigation
perf(arrow): use shared membership sets for large IN predicates #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexanderbianchi
wants to merge
9
commits into
apache:main
Choose a base branch
from
alexanderbianchi:codex/arrow-in-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a16ffe7
perf(arrow): use shared membership sets for large IN predicates
alexanderbianchi 0c658b4
perf(arrow): use foldhash for string IN lookups
alexanderbianchi 1ca9b4b
perf(arrow): probe dictionary values for IN predicates
alexanderbianchi 3c20cdf
test(arrow): assert which IN column types use the index
alexanderbianchi eb8026f
test(expr): check bound IN index sharing through NOT rewrites
alexanderbianchi 6c9ea06
perf(arrow): use foldhash for integer IN indexes
alexanderbianchi 63ebab2
perf(arrow): choose IN index cutoffs in the reader by type
alexanderbianchi 25daa58
test(arrow): probe indexes built from bound IN predicates
alexanderbianchi 5c7d3f6
test(expr): clone bound IN predicates before building the index
alexanderbianchi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revert the last commit if we don't want this new dep. But this is what DF uses as well, and did benchmark better.
Iceberg rust bench
Datafusion Bench
apache/datafusion-iceberg#130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it. DataFusion already depends on
foldhash = "0.2", so DataFusion-based consumers already build it, and foldhash has no dependencies of its own.Should
IntandLonguseFixedStatetoo? FNV hashes one byte at a time, so eachi64row costs 8 dependent multiplies before the probe starts. This is the Int64 arm ofprobe_setat a16ffe7, release build on aarch64:foldhash hashes a single integer with one widening multiply in
finish. WithHashSet<i64, FixedState>the same arm becomes:Could you add an Int64 case to the reader benchmark and compare the two hashers? If it holds up,
SetIndexwould also use one hasher for every variant.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adressed in 6c9ea06
benchmark in 2d55fc4
Description includes integer cases