Skip to content

Conversation

@yangxk1
Copy link
Contributor

@yangxk1 yangxk1 commented Jun 17, 2025

Reason for this PR

As described in issue #704, the current Java library version is outdated and not working.

What changes are included in this PR?

  • Updated the version of libarrow libraries

  • Set Ubuntu version to ubuntu-22.04

  • Changed the namespace from gar / GraphArchive to graphar for consistency with C++ library

  • Refactored Java interfaces to depend on version v0.12.0 of the C++ library

Are these changes tested?

yes

Are there any user-facing changes?

yes

@lixueclaire lixueclaire requested a review from Thespica June 19, 2025 07:03
@Thespica Thespica requested a review from Copilot June 20, 2025 16:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Java library in GraphAr by refactoring the interfaces to consistently use StdSharedPtr wrappers, renaming namespaces and targets for consistency, and fixing CI configuration.

  • Changes include:
    • Replacing direct type usage (e.g. VertexInfo, EdgeInfo) with StdSharedPtr wrappers in tests and API interfaces.
    • Updating JNI and CMake build targets to use “graphar” consistently and bumping the C++ dependency version to v0.12.0.
    • Adjusting the CI environment to Ubuntu 22.04 and updating Arrow dependency versions.

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated no comments.

File Description
maven-projects/java/src/main/java/org/apache/graphar/util/JNILibraryName.java Renamed the JNI library name from “gar-jni” to “graphar-jni”.
maven-projects/java/cmake/graphar-cpp.cmake Updated dependency version to “v0.12.0” and maintained library naming consistency.
Other files across the codebase Refactored API and tests to use StdSharedPtr wrappers as per the new design.
Comments suppressed due to low confidence (2)

maven-projects/java/src/main/java/org/apache/graphar/util/JNILibraryName.java:23

  • Ensure that the JNI library renaming from 'gar-jni' to 'graphar-jni' is propagated consistently across all build configurations and dependent modules.
    public static final String GAR_JNI_LIBRARY_NAME = "graphar-jni";

maven-projects/java/cmake/graphar-cpp.cmake:68

  • Confirm that updating the graphar C++ dependency version to v0.12.0 aligns with all module expectations and dependency requirements.
    set(GAR_VERSION_TO_BUILD "v0.12.0")

@yangxk1 yangxk1 requested a review from Thespica June 30, 2025 02:33
Copy link
Contributor

@Thespica Thespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
Thank you!

@yecol yecol merged commit 2ccaf7c into apache:main Jul 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants