-
Notifications
You must be signed in to change notification settings - Fork 82
feat(java): update Java library and fix CI #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Java library in GraphAr by refactoring the interfaces to consistently use StdSharedPtr wrappers, renaming namespaces and targets for consistency, and fixing CI configuration.
- Changes include:
• Replacing direct type usage (e.g. VertexInfo, EdgeInfo) with StdSharedPtr wrappers in tests and API interfaces.
• Updating JNI and CMake build targets to use “graphar” consistently and bumping the C++ dependency version to v0.12.0.
• Adjusting the CI environment to Ubuntu 22.04 and updating Arrow dependency versions.
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| maven-projects/java/src/main/java/org/apache/graphar/util/JNILibraryName.java | Renamed the JNI library name from “gar-jni” to “graphar-jni”. |
| maven-projects/java/cmake/graphar-cpp.cmake | Updated dependency version to “v0.12.0” and maintained library naming consistency. |
| Other files across the codebase | Refactored API and tests to use StdSharedPtr wrappers as per the new design. |
Comments suppressed due to low confidence (2)
maven-projects/java/src/main/java/org/apache/graphar/util/JNILibraryName.java:23
- Ensure that the JNI library renaming from 'gar-jni' to 'graphar-jni' is propagated consistently across all build configurations and dependent modules.
public static final String GAR_JNI_LIBRARY_NAME = "graphar-jni";
maven-projects/java/cmake/graphar-cpp.cmake:68
- Confirm that updating the graphar C++ dependency version to v0.12.0 aligns with all module expectations and dependency requirements.
set(GAR_VERSION_TO_BUILD "v0.12.0")
maven-projects/java/src/main/java/org/apache/graphar/graphinfo/AdjacentList.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/graphinfo/EdgeInfo.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/graphinfo/Property.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/stdcxx/StdPair.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/stdcxx/StdSharedPtr.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/util/GrapharStaticFunctions.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/util/InfoVersion.java
Outdated
Show resolved
Hide resolved
maven-projects/java/src/main/java/org/apache/graphar/util/Result.java
Outdated
Show resolved
Hide resolved
Thespica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Thank you!
Reason for this PR
As described in issue #704, the current Java library version is outdated and not working.
What changes are included in this PR?
Updated the version of
libarrowlibrariesSet Ubuntu version to
ubuntu-22.04Changed the namespace from
gar/GraphArchivetographarfor consistency with C++ libraryRefactored Java interfaces to depend on version
v0.12.0of the C++ libraryAre these changes tested?
yes
Are there any user-facing changes?
yes