Skip to content

Conversation

@yangxk1
Copy link
Contributor

@yangxk1 yangxk1 commented Jul 14, 2025

Reason for this PR

Implemented multi-property read/write as described in #660.

What changes are included in this PR?

graph_info: add cardinality to YAML to indicate multi-property types.
chunk_reader: convert schema.

Are these changes tested?

yes

Test cases can be found in issue apache/incubator-graphar-testing#30

Are there any user-facing changes?

yes

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 92.77567% with 19 lines in your changes missing coverage. Please review.

Project coverage is 64.21%. Comparing base (eb4984d) to head (a396bb2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cpp/src/graphar/types.h 70.83% 7 Missing ⚠️
cpp/src/graphar/graph_info.cc 82.60% 4 Missing ⚠️
...scala/org/apache/graphar/reader/VertexReader.scala 85.71% 0 Missing and 3 partials ⚠️
...scala/org/apache/graphar/writer/VertexWriter.scala 87.50% 2 Missing and 1 partial ⚠️
...n/scala/org/apache/graphar/graph/GraphReader.scala 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #719      +/-   ##
============================================
- Coverage     66.65%   64.21%   -2.44%     
- Complexity      226      236      +10     
============================================
  Files            21       97      +76     
  Lines          2012    13183   +11171     
  Branches        179     1247    +1068     
============================================
+ Hits           1341     8466    +7125     
- Misses          515     4556    +4041     
- Partials        156      161       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lixueclaire lixueclaire merged commit 883d7eb into apache:main Jul 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants