Add fallback for log truncation issue in Delta source#782
Add fallback for log truncation issue in Delta source#782vinishjail97 wants to merge 1 commit intomainfrom
Conversation
| return deltaCommitInstant.equals(instant) || deltaCommitInstant.isBefore(instant); | ||
| try { | ||
| DeltaHistoryManager.Commit deltaCommitAtOrBeforeInstant = | ||
| deltaLog.history().getActiveCommitAtTime(Timestamp.from(instant), true, false, true); |
There was a problem hiding this comment.
3rd #argument seems to be "mustBeRecreatable" and is false. if we just make this to true wont it be enough?
|
Closing this draft PR. The approach here — calling Additionally, the PR body was never filled out and the implementation was left as a draft without tests. Given it has been idle for ~3 months with the approach still in question, closing for now. If the VACUUM-induced log truncation issue resurfaces, the fix should come with a clear description of the failure scenario, a unit/integration test that reproduces it, and a more targeted approach (e.g., verifying the |
Important Read
What is the purpose of the pull request
(For example: This pull request implements the sync for delta format.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)