JCR-5140: Improve support for generating namespace prefixes #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Jul 3, 2025
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/commons/NamespaceHelper.java
Outdated
Show resolved
Hide resolved
|
reschke
changed the title
mbaedke
requested changes
Sep 29, 2025
| prefix = prefix.replaceAll("[\\/:]+", "-"); | ||
|
|
||
| // strip trailing replacement character | ||
| if (prefix.endsWith("-")) { |
Contributor
Author
There was a problem hiding this comment.
That was already taken care of by the regexp, but more clarity and more test coverage do not hurt
|
mbaedke
approved these changes
Sep 30, 2025
reschke
added a commit
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.