JCR-5161: NamespaceHelper - get NamespaceRegistry only once #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaedke
approved these changes
Jul 7, 2025
kwin
reviewed
Jul 7, 2025
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/commons/NamespaceHelper.java
Outdated
Show resolved
Hide resolved
kwin
reviewed
Jul 7, 2025
| throws RepositoryException { | ||
| NamespaceRegistry registry = | ||
| session.getWorkspace().getNamespaceRegistry(); | ||
| NamespaceRegistry registry = getNamespaceRegistry(); |
Member
There was a problem hiding this comment.
Any pointers on how much overhead this call is? I was assuming this is not leading to complex and expensive object creations
Contributor
Author
There was a problem hiding this comment.
apparently it does in Oak - see https://issues.apache.org/jira/browse/OAK-11784 - it's of course a good question why it is expensive in Oak. @mbaedke - any idea?
Contributor
There was a problem hiding this comment.
I don't think that this is is an expensive operation by itself. It's rather a problem if there are a lot of registered prefixes (see the excerpt of the stacktrace in https://issues.apache.org/jira/browse/OAK-11784), which leads to many invocations of this method.
|
reschke
added a commit
that referenced
this pull request
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.