JCR-5183: Vote Template should be clear about the fact that running the check script in "sh" will not work #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he check script in "sh" will not work
…he check script in "sh" will not work
|
mbaedke
reviewed
Aug 11, 2025
| The command for running automated checks against this release candidate is: | ||
| The command for running automated checks requires the use of a *nix | ||
| shell such as "bash" ("sh" will not work due to the lack of certain | ||
| built-in commands). On Windows, use Cygwin or WSL. |
Contributor
There was a problem hiding this comment.
Git Bash is also an option. Many people will have that already installed.
Member
There was a problem hiding this comment.
For me the shebang and the executable flag set in check-release.sh is totally sufficient. Just recommend using it as $ ./check-release.sh jackrabbit ${project.version} ${checksum} of the SVN checkout should work just fine.
Contributor
Author
There was a problem hiding this comment.
I think the comment is still valuable.
Member
There was a problem hiding this comment.
The comment is good but I would change line 193.
mbaedke
approved these changes
Aug 11, 2025
…he check script in sh will not work - fix instruction just to invoke the script with specifying the shell (ack kwin)
reschke
added a commit
that referenced
this pull request
Jan 10, 2026
…he check script in "sh" will not work (#279) * JCR-5183: Vote Template should be clear about the fact that running the check script in "sh" will not work * JCR-5183: Vote Template should be clear about the fact that running the check script in "sh" will not work * JCR-5183: Vote Template should be clear about the fact that running the check script in sh will not work - fix instruction just to invoke the script with specifying the shell (ack kwin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(same TBD in Oak)