-
Notifications
You must be signed in to change notification settings - Fork 973
Initial support Spark 4.1 #7254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7254 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 697 697
Lines 43587 43610 +23
Branches 5893 5893
======================================
- Misses 43587 43610 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b5f0fb to
a6d5660
Compare
| <profile> | ||
| <id>spark-4.1</id> | ||
| <modules> | ||
| <module>extensions/spark/kyuubi-spark-connector-hive</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it passes compile, but not test
| } | ||
|
|
||
| test("arrow-based query metrics") { | ||
| // TODO: the issue is being investigated Fu Chen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cfmcgrady, as we discussed, this seems to be a spark side bug
| result = testPrematureExitForControlCli(logArgs, "") | ||
| assert(result.contains(s"Submitted application: $sparkBatchTestAppName")) | ||
| assert(result.contains("Shutdown hook called")) | ||
| assert(result.contains("Successfully stopped SparkContext")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPARK-54259 demotes the log level of "Shutdown hook called" to debug
.../src/test/scala/org/apache/kyuubi/engine/spark/operation/SparkArrowbasedOperationSuite.scala
Outdated
Show resolved
Hide resolved
…uubi/engine/spark/operation/SparkArrowbasedOperationSuite.scala Co-authored-by: Cheng Pan <chengpan@apache.org>
|
thanks, merged to master! |
Why are the changes needed?
Switch to Python 3.11 for Spark 4 in GHA, due to the support of Python 3.9 is EOL and dropped by Spark 4.1
How was this patch tested?
GHA.
Was this patch authored or co-authored using generative AI tooling?
No.