This repository was archived by the owner on Dec 19, 2020. It is now read-only.
tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path#13
Open
simonhf wants to merge 3 commits intoapache:masterfrom
Open
tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path#13simonhf wants to merge 3 commits intoapache:masterfrom
simonhf wants to merge 3 commits intoapache:masterfrom
Conversation
…and optionally shorten file path
|
@rgoers Like the other commit, looks good in theory, but I'd like to get a unit test up to make sure it's behaving properly before committing this to develop. |
Member
|
OK. Please go ahead with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by [1]. Useful if log4php is itself wrapped by a caller class which you do not want showing up in syslog as the file:line. Plus, if file is unnecessarily long then this patch allows the path to be shortened.
[1] http://stackoverflow.com/questions/15219327/php-log4php-dynamically-set-fileline-column