Skip to content

test(dev): exempt security-tools from the vetted-ops stable-path check - #2178

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/stable-path-test-security-tools
Nov 18, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/stable-path-test-security-tools

Conversation

@potiuk

@potiuk potiuk commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

  • main fails test_every_stable_magpie_path_a_skill_runs_is_linked_by_vetted_ops since feat(setup): run cve-tool through a fixed plugin path #2132: the security skills now name ~/.claude/magpie/security-tools, which the magpie-security-tools session hook links, not vetted-ops'. The test treats every ~/.claude/magpie/<name> a skill names as vetted-ops' job.
  • Exempt security-tools, as adversarial-review already is. Its link is covered by tools/security-management/tests/test_framework_link_hook.py (test_the_stable_path_names_the_plugin_tools).

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other:

Test plan

  • tools/dev: test_every_stable_magpie_path_a_skill_runs_is_linked_by_vetted_ops passes (fails on main, CI run 44210754546); ruff check / ruff format --check pass
  • tools/security-management/tests/test_framework_link_hook.py passes (7 tests)

Linked issues

Unblocks #2161, #2162 and #2163, which run this test after rebasing onto main.

🤖 Generated with Claude Code

@potiuk potiuk added capability:fix Implement code change to resolve an issue family:dev Repo dev: .asf.yaml, spec-loop specs, Node manifests, .claude/settings.json labels Nov 18, 2026
@potiuk
potiuk enabled auto-merge (squash) November 18, 2026 01:15
@potiuk
potiuk disabled auto-merge November 18, 2026 01:16
@potiuk
potiuk enabled auto-merge (squash) November 18, 2026 01:18
@potiuk
potiuk disabled auto-merge November 18, 2026 01:18
apache#2132 made the security skills run their record client from
~/.claude/magpie/security-tools, which the magpie-security-tools session
hook links, not vetted-ops'. The check that every stable path a skill
names is linked by vetted-ops therefore failed on main. Exempt it, as
adversarial-review already is; test_framework_link_hook.py covers the
link itself.

Generated-by: Claude Opus 5
@potiuk
potiuk force-pushed the fix/stable-path-test-security-tools branch from f89e261 to 8bbf99f Compare November 18, 2026 01:18
@potiuk
potiuk merged commit 3fdae28 into apache:main Nov 18, 2026
10 checks passed
@github-actions github-actions Bot added family:tools tools/* family:ci .github workflows, prek, validators substrate:framework-dev Tool substrate: build / validate / eval the framework itself labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capability:fix Implement code change to resolve an issue family:ci .github workflows, prek, validators family:dev Repo dev: .asf.yaml, spec-loop specs, Node manifests, .claude/settings.json family:tools tools/* substrate:framework-dev Tool substrate: build / validate / eval the framework itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant