Repository navigation
test(dev): exempt security-tools from the vetted-ops stable-path check - #2178
Merged
Merged
Conversation
potiuk
enabled auto-merge (squash)
November 18, 2026 01:15
potiuk
disabled auto-merge
November 18, 2026 01:16
potiuk
enabled auto-merge (squash)
November 18, 2026 01:18
potiuk
disabled auto-merge
November 18, 2026 01:18
apache#2132 made the security skills run their record client from ~/.claude/magpie/security-tools, which the magpie-security-tools session hook links, not vetted-ops'. The check that every stable path a skill names is linked by vetted-ops therefore failed on main. Exempt it, as adversarial-review already is; test_framework_link_hook.py covers the link itself. Generated-by: Claude Opus 5
potiuk
force-pushed
the
fix/stable-path-test-security-tools
branch
from
November 18, 2026 01:18
f89e261 to
8bbf99f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfailstest_every_stable_magpie_path_a_skill_runs_is_linked_by_vetted_opssince feat(setup): run cve-tool through a fixed plugin path #2132: the security skills now name~/.claude/magpie/security-tools, which the magpie-security-tools session hook links, not vetted-ops'. The test treats every~/.claude/magpie/<name>a skill names as vetted-ops' job.security-tools, asadversarial-reviewalready is. Its link is covered bytools/security-management/tests/test_framework_link_hook.py(test_the_stable_path_names_the_plugin_tools).Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
tools/dev:test_every_stable_magpie_path_a_skill_runs_is_linked_by_vetted_opspasses (fails onmain, CI run 44210754546);ruff check/ruff format --checkpasstools/security-management/tests/test_framework_link_hook.pypasses (7 tests)Linked issues
Unblocks #2161, #2162 and #2163, which run this test after rebasing onto
main.🤖 Generated with Claude Code