Repository navigation
fix(asf): let the Write role bypass main's CI ruleset, as airflow does - #2190
Merged
Merged
Conversation
GitHub refuses the magpie-committers team as a ruleset bypass actor, so the `main` ruleset was never created and main had no protection. Follow apache/airflow: a raw "Require CI on main" ruleset with the required checks, bypassable by the Write repository role (actor_id 4), which only committers hold and which ASF Infra grants from LDAP; and a "Branch protection" ruleset with no bypass for linear history, resolved conversations, the pull-request requirement, and no branch deletion or force push. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhas had no protection since #2184: the classic protection was removed, and ASF Infra's.asf.yamlrun could not create themainruleset. After #2189 fixed the first error, the second one is:GitHub does not accept the
magpie-committersteam as a bypass actor. apache/airflow hit the same problem withairflow-committersand solved it with the Write repository role instead; this follows its.asf.yaml:zizmor,prekandtests-okrequired checks, not strict. Bypass actor: the Write repository role (actor_id: 4,bypass_mode: always). On this repository only committers hold Write, granted by ASF Infra from the project's LDAP group, so the bypass list follows committer changes with no update to.asf.yaml. The externalcollaboratorsget Triage, not Write.mainneeds a PR and nobody can bypass this ruleset, the CI bypass cannot be used to push tomaindirectly.protected_branches: ~stays, so classic protection does not come back and block the bypass.Type of change
.asf.yaml)Test plan
gh api repos/apache/magpie/rules/branches/mainlists the required status checks, pull request, linear history, deletion and non-fast-forward rules; a PR with a failing required check shows as blocked, with the bypass option offered to committers.🤖 Generated with Claude Code