Skip to content

fix(release): resume draft CLI releases by ID #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M4n5ter merged 1 commit into from
Aug 18, 2026
Merged

fix(release): resume draft CLI releases by ID #3200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/release-cli-finalize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ jobs:
exit 1
fi

release_endpoint="repos/$GITHUB_REPOSITORY/releases/tags/$RELEASE_TAG"
release_json="$RUNNER_TEMP/github-release.json"
release_assets=(
"$RELEASE_DIRECTORY/$RELEASE_TARBALL_NAME"
Expand All @@ -203,7 +202,12 @@ jobs:
"$RELEASE_DIRECTORY/release.json"
)

if ! gh api "$release_endpoint" > "$release_json" 2>/dev/null; then
# The REST release-by-tag endpoint does not return drafts. Resolve both draft and
# published releases through gh, then use the immutable API URL for exact reads.
if ! release_api_url="$(gh release view "$RELEASE_TAG" \
--repo "$GITHUB_REPOSITORY" \
--json apiUrl \
--jq .apiUrl 2>/dev/null)"; then
if ! gh release create "$RELEASE_TAG" \
--repo "$GITHUB_REPOSITORY" \
--verify-tag \
Expand All @@ -213,8 +217,16 @@ jobs:
--notes-file "$RELEASE_DIRECTORY/release-notes.md"; then
echo "GitHub Release creation did not confirm success; inspecting remote state" >&2
fi
gh api "$release_endpoint" > "$release_json"
release_api_url="$(gh release view "$RELEASE_TAG" \
--repo "$GITHUB_REPOSITORY" \
--json apiUrl \
--jq .apiUrl)"
fi
if [[ ! "$release_api_url" =~ ^https://api\.github\.com/repos/$GITHUB_REPOSITORY/releases/[1-9][0-9]*$ ]]; then
echo "GitHub Release API URL is not bound to the expected repository: $release_api_url" >&2
exit 1
fi
gh api "$release_api_url" > "$release_json"

release_draft="$(RELEASE_JSON="$release_json" node -e '
const fs = require("node:fs");
Expand Down Expand Up @@ -243,7 +255,7 @@ jobs:
--notes-file "$RELEASE_DIRECTORY/release-notes.md"
fi

gh api "$release_endpoint" > "$release_json"
gh api "$release_api_url" > "$release_json"
node scripts/release-cli-publication.mjs validate-github-release \
"$RELEASE_DIRECTORY" \
"$release_json"
Expand Down
3 changes: 3 additions & 0 deletions scripts/release-cli-workflow-policy.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ test('finalize propagates verified artifacts and idempotently publishes an exact
assert.match(publish, /gh release create[\s\S]*?--draft/u);
assert.match(publish, /gh release upload[\s\S]*?--clobber/u);
assert.match(publish, /gh release edit[\s\S]*?--draft=false/u);
assert.match(publish, /gh release view[\s\S]*?--json apiUrl/u);
assert.match(publish, /gh api "\$release_api_url"/u);
assert.doesNotMatch(publish, /releases\/tags\/\$RELEASE_TAG/u);
assert.match(publish, /--prerelease/u);
assert.match(publish, /--latest=false/u);
assert.match(publish, /validate-github-release/u);
Expand Down
Loading