Skip to content

fix(release): carry DISCLAIMER-WIP in the npm CLI tarball #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 18, 2026
Merged

fix(release): carry DISCLAIMER-WIP in the npm CLI tarball #3220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/cli-package-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- '.npmrc'
- 'LICENSE'
- 'NOTICE'
- 'DISCLAIMER-WIP'
- 'package.json'
- 'package-lock.json'
- 'patches/**'
Expand Down Expand Up @@ -38,6 +39,7 @@ on:
- '.npmrc'
- 'LICENSE'
- 'NOTICE'
- 'DISCLAIMER-WIP'
- 'package.json'
- 'package-lock.json'
- 'patches/**'
Expand Down
6 changes: 6 additions & 0 deletions scripts/release-cli-package.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,9 @@ function copyReleaseDocuments() {
copyFileSync(join(cliSource, 'README.zh-CN.md'), join(stageRoot, 'README.zh-CN.md'));
copyFileSync(join(repoRoot, 'LICENSE'), join(stageRoot, 'LICENSE'));
copyFileSync(join(repoRoot, 'NOTICE'), join(stageRoot, 'NOTICE'));
// Incubator policy: podling releases carry the incubating disclaimer, kept
// next to LICENSE/NOTICE. The npm tarball is a release like the installers.
copyFileSync(join(repoRoot, 'DISCLAIMER-WIP'), join(stageRoot, 'DISCLAIMER-WIP'));
copyFileSync(
join(cliSource, 'THIRD_PARTY_NOTICES.txt'),
join(stageRoot, 'THIRD_PARTY_NOTICES.txt'),
Expand Down Expand Up @@ -497,6 +500,7 @@ function writeReleaseManifest(cli, publishable) {
'README.zh-CN.md',
'LICENSE',
'NOTICE',
'DISCLAIMER-WIP',
'THIRD_PARTY_NOTICES.txt',
],
dependencies,
Expand All @@ -510,6 +514,7 @@ function validateStaging() {
const required = [
'dist/cli.js',
'README.zh-CN.md',
'DISCLAIMER-WIP',
'node_modules/@maka/runtime/dist/workers/filesystem-worker.js',
'node_modules/@maka/runtime-host/dist/execution-candidate-main.js',
'packages/eval/dist/harbor-external-subject.js',
Expand Down Expand Up @@ -603,6 +608,7 @@ function validatePackedFiles(files, expectedDependencyManifests) {
}
const requiredPacked = [
'dist/cli.js',
'DISCLAIMER-WIP',
'node_modules/@maka/runtime/dist/workers/filesystem-worker.js',
'node_modules/@maka/runtime-host/dist/execution-candidate-main.js',
'packages/eval/harbor/relay_agent.py',
Expand Down
3 changes: 3 additions & 0 deletions scripts/smoke-release-cli-package.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ function validateReleaseArtifact(path) {

function validateInstalledRuntimeFiles(packageRoot) {
for (const path of [
// Incubator policy: the installed package carries the incubating
// disclaimer next to LICENSE/NOTICE, like every other Maka release.
'DISCLAIMER-WIP',
'node_modules/@maka/runtime/dist/workers/filesystem-worker.js',
'node_modules/@maka/runtime-host/dist/execution-candidate-main.js',
'node_modules/@maka/eval/dist/index.js',
Expand Down
Loading