Skip to content

test(desktop): expand Storybook smoke theme coverage - #4042

Open
Yx01-me wants to merge 5 commits into
apache:mainfrom
Yx01-me:feat/story_book_palette_scheme
Open

test(desktop): expand Storybook smoke theme coverage#4042
Yx01-me wants to merge 5 commits into
apache:mainfrom
Yx01-me:feat/story_book_palette_scheme

Conversation

@Yx01-me

@Yx01-me Yx01-me commented Aug 27, 2026

Copy link
Copy Markdown

Summary

  • Run every Storybook story with the default palette in both light and dark color schemes.
  • Run the Native Conversation reference story across all 11 palettes and both color schemes.
  • Include scheme and palette context in Storybook smoke URLs, diagnostics, and tests without expanding the full catalog across every palette.

Refs #3942

Verification

  • node --test scripts/ci-test-plan.test.mjs scripts/storybook-visual-smoke.test.mjs scripts/ax-tree-audit.test.mjs
  • npm run lint
  • npm run format:check
  • npm run typecheck
  • npm run build
  • npx knip --workspace apps/desktop
  • npx knip --workspace packages/ui
  • npm --workspace @maka/desktop run smoke:storybook — 410 renders across 195 stories

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with the Storybook theme job matrix implementation, tests, and local verification.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/M Under 500 readable lines label Aug 27, 2026

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for broadening the Storybook smoke coverage with a bounded job matrix. Using both color schemes for ordinary stories and the full palette set for one representative product story is a sensible balance.

I found one local-entrypoint regression and left it inline. The contract tests pass, but the hosted test check has not run on this head, and the smoke command currently depends on a Core build that it does not establish itself. I’m holding approval for that fix.

Review analysis was assisted by Codex; Astro-Han reviewed the result and owns this review.

简体中文

谢谢用有界的任务矩阵扩展 Storybook smoke 覆盖。普通 story 覆盖两种色彩模式,同时只让一个代表性的产品 story 覆盖全部 palette,这个取舍合理。

我发现了一处本地入口回归,已经留在行内。Contract tests 已通过,但当前 head 还没有运行 GitHub test check,而且 smoke 命令依赖一个它自己没有保证完成的 Core build,因此这里先不 Approve。

本次审查分析由 Codex 协助;Astro-Han 审阅了结果并对本次 Review 负责。

Comment thread scripts/storybook-visual-smoke.mjs

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the Storybook smoke entrypoint self-contained. I reviewed exact head 167ec48e043721cafed6d66bfaa36d1800f2cb13.

The original problem and scope are well defined: exercise both color schemes for every story while sampling the complete palette space on one representative product story, rather than multiplying the entire catalog by every palette. The job generator keeps that matrix bounded and carries palette/scheme facts consistently into URLs, diagnostics, and tests.

The earlier P2 is closed at the local command boundary. presmoke:storybook now builds @maka/core before the smoke script imports the shared palette authority, so a clean checkout no longer depends on a previous root build. This reuses npm lifecycle composition instead of copying the palette list or creating another authority.

I found no remaining P0-P2 on this head. GitHub currently reports no hosted checks for the latest merge head, so this approval is not a merge-ready claim; please obtain a green exact-head test before merging.

中文对照

感谢把 Storybook smoke 入口做成自包含。我复核了最新提交 167ec48e043721cafed6d66bfaa36d1800f2cb13

问题和范围定义合理:每个 story 覆盖 light/dark,但只让一个代表性产品 story 覆盖全部 palette,避免把整个 catalog 与所有 palette 做笛卡尔积。job generator 保持了有界矩阵,并让 palette/scheme 信息一致进入 URL、诊断和测试。

之前的 P2 已在本地命令边界闭合。presmoke:storybook 会在 smoke script 导入共享 palette authority 之前构建 @maka/core,因此干净 checkout 不再依赖之前跑过 root build。这里复用了 npm lifecycle composition,没有复制 palette 列表或创建第二套权威。

这个 head 上没有发现剩余的 P0-P2。GitHub 当前没有报告最新 merge head 的 hosted checks,因此这次批准不代表已经满足合并条件;合并前仍需要绿色的 exact-head test

AI-assisted review: Codex checked the incremental command composition and bounded matrix; I independently verified the exact head, scope, and severity.

Resolve the Storybook smoke conflict by retaining main's dark-theme sentinels while applying full palette-by-scheme coverage to the reference story.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants