feat(i18n-ko): native surfaces and E2E fixtures - #4515
Draft
scs0209 wants to merge 17 commits into
Draft
Conversation
Generated-by: ChatGPT
Generated-by: ChatGPT
Generated-by: ChatGPT
Generated-by: ChatGPT
Generated-by: ChatGPT
Generated-by: ChatGPT
Generated-by: ChatGPT
Generated-by: ChatGPT
4 tasks
scs0209
force-pushed
the
feat/i18n-ko-native-e2e-3980
branch
from
September 1, 2026 23:01
e33433a to
1e37f24
Compare
…3980) - Add ko to UI_LOCALES and resolve ko-KR system locales - Localize startup/quit/boot, diagnostics, and notification native copy - Add ko E2E fixture flags and ko-locale spec - Add ko stubs to UiCatalog entries (renderer English fallback until apache#3977–apache#3979) Generated-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the ko: EN stub with a dedicated KO translation block. Generated-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
scs0209
force-pushed
the
feat/i18n-ko-native-e2e-3980
branch
from
September 1, 2026 23:10
1e37f24 to
16f0432
Compare
github-actions
Bot
added
effort/XXL
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire
kothrough core locale resolution, desktop native surfaces, and E2E fixtures. This follows the same pattern as #3853 (zh-TW): Korean copy for startup/quit/boot dialogs, diagnostics, notifications, permission overlay, and related main-process fallbacks; E2E fixture flags acceptko/ko-krwithout thetoLowerCaseregression fixed for Chinese locales in #3853 review.Renderer
UiCatalogtypes require akokey oncekois inUI_LOCALES. Catalogs outside the #3977–#3979 renderer slices use English stubs for now;session-collaboration-copyincludes a realKOblock.Fixes #3980
Verification
npm run build:test— passnode --test packages/core/dist/__tests__/ui-locale.test.js— passnode --test apps/desktop/dist/main/__tests__/e2e-fixture-locale.test.js— passko-locale.spec.ts) — not run locally (dev server not started)npm run lint/npm run format:check— not run for the full workspaceAI use
Tool(s) and scope: Cursor — implementation, translation stubs, tests, and PR text. The
update(i18n-ko): session-collaboration…commit includes aGenerated-by: Cursortrailer.Checklist
Does this PR entail a change in behavior?