fix(desktop): load desktop stories on Windows with a config-relative glob - #4517
Merged
Merged
Conversation
…glob
The desktop stories glob was built with resolve(REPO_ROOT, ...), which on
Windows hands the globber a backslash absolute path; glob matchers treat
backslashes as escape characters, so the pattern matched nothing and
Storybook silently indexed only packages/ui/stories (53 entries, zero
desktop story files). The neighboring packages/ui entry already uses a
forward-slash config-relative glob, which is why those kept working.
Use the same config-relative form for the desktop stories ('../stories/
**/*.stories.@(ts|tsx)'). index.json goes from 53 entries to 251 on
Windows, including all 11 desktop story files; Linux behavior is
unchanged since the relative glob resolves against the same config dir.
Fixes apache#4516
Generated-by: GLM-5.3-Flash (ZCode)
ggbdpq
force-pushed
the
fix/storybook-windows-glob
branch
from
September 2, 2026 04:11
8ec1e70 to
402e3df
Compare
Astro-Han
approved these changes
Sep 2, 2026
Astro-Han
left a comment
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Approving 402e3df1. The desktop entry now uses the same config-relative form the packages/ui entry has always used, so the config directory resolves it on every platform; Linux behaviour and CI are unchanged. Thanks for the index.json before and after counts.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/desktopsilently indexed onlypackages/ui/stories(53 entries, zero desktop story files): the desktop stories glob was built withresolve(REPO_ROOT, ...), handing the globber a backslash absolute path, and glob matchers treat backslashes as escape characters (fix(desktop): desktop stories never load in Storybook on Windows (backslash stories glob) #4516).packages/uientry already uses ('../stories/**/*.stories.@(ts|tsx)'), so it resolves against the config dir on every platform.Verification
npm run storybook(apps/desktop), then fetchhttp://localhost:6006/index.jsonproduct-agent-graph--*/product-onboarding-*/ etc. After: 251 entries including all 11 desktop story files; the Product/Agent Graph stories render and playnpm run format:checknpm run check:asf-headersAI use
Analysis and the fix were produced with GLM-5.3-Flash (ZCode) under the contributor's direction; the contributor reviewed and is the human contributor of record.
Checklist