fix(deps): clear the CLI production audit - #4588
Closed
Astro-Han wants to merge 1 commit into
Closed
Conversation
`fast-uri` (high) and `qs` (moderate) advisories landed on transitive production dependencies of the CLI, so `release:cli:pack` fails its audit gate and every job that packages the CLI goes red — main included. The lockfile moves to the patched versions, and `packages/cli/THIRD_PARTY_NOTICES.txt` moves with it, because the notice file records the exact versions the audit just changed and its own check fails otherwise. The three open Dependabot PRs do not cover this: apache#4586 and apache#4587 bump the same packages in `packages/eval/harbor/deepseek-harness-toolchain`, a different lockfile, and apache#4585 is a dev dependency the production audit does not read. `@xmldom/xmldom` comes along here because `npm audit fix` resolves the root lockfile as a whole; if apache#4585 lands first this hunk is already what it wants. Generated-by: Claude Code
Contributor
Author
|
Superseded by #4578, which landed the same root-lockfile bumps on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build CLI release candidatefails on main and on every open PR:Two advisories landed on transitive production dependencies of the CLI —
fast-uri(high) andqs(moderate).scripts/release-cli-package.mjsaudits production dependencies before it packs, so the gate is doing its job; the lockfile has to move.packages/cli/THIRD_PARTY_NOTICES.txtmoves with it. The notice file records the exact resolved versions, andcheck:cli-third-party-notices— the next step in the same script — fails withfast-uri@3.1.5: missing from package-lock.jsonif only the lockfile changes. Regenerated withnode scripts/generate-third-party-notices.mjs --target cli.@xmldom/xmldom(dev) is in the diff becausenpm audit fixresolves the root lockfile as a whole.Why the open Dependabot PRs do not cover this
packages/eval/harbor/deepseek-harness-toolchain/package-lock.json. That is a different lockfile; the CLI audit reads the root one.@xmldom/xmldomis a dev dependency and the audit runs--omit=dev.Merging all three leaves the gate red.
Verification
npm audit --omit=dev— 2 vulnerabilities (1 high, 1 moderate) before, 0 after.node scripts/generate-third-party-notices.mjs --target cli --check— OK.npm ciclean.npm run release:cli:pack -- --allow-dirtygets past both gates above and then stops oncargo deny, which is not installed on this machine. CI has it.AI use
Select exactly one:
Tool(s) and scope: Claude Code diagnosed the failing gate, applied
npm audit fix, regenerated the notice file and drafted this description; the scope and the decision to keep it separate from the e2e work in #4577 were the author's.Checklist
Does this PR entail a change in behavior?