refactor(desktop): retire obsolete Astryx workarounds - #4628
Merged
Conversation
M4n5ter
force-pushed
the
fix/sidebar-resize-root-cause
branch
from
September 3, 2026 07:17
07ba0f3 to
291ab4e
Compare
Astryx now owns the resize-handle hit area and ChatLayout flex contract that Maka still overrode. Remove those stale compatibility rules, delete the compositor-sensitive E2E that duplicated vendor behavior, and retain only the product-owned sidebar geometry check.\n\nGenerated-by: OpenAI Codex
M4n5ter
force-pushed
the
fix/sidebar-resize-root-cause
branch
from
September 3, 2026 07:23
291ab4e to
97366d2
Compare
Astro-Han
approved these changes
Sep 3, 2026
Contributor
|
LGTM |
ggbdpq
pushed a commit
to ggbdpq/maka
that referenced
this pull request
Sep 4, 2026
Astryx now owns the resize-handle hit area and ChatLayout flex contract that Maka still overrode. Remove those stale compatibility rules, delete the compositor-sensitive E2E that duplicated vendor behavior, and retain only the product-owned sidebar geometry check. Generated-by: OpenAI Codex Generated-by: GLM-5.3-Flash (ZCode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
Retire three compatibility rules whose contracts are now owned by the pinned Astryx 0.5.2 dependency:
Fixes #4622
Root cause
Dependency upgrades did not discharge Maka's temporary compatibility rules. The resize E2E was added after the pinned Astryx package already contained and tested the hit-area fix, so it duplicated vendor behavior through two synthetic Electron drags. The reverse-drag flake exposed that stale ownership boundary; adding more timing or diagnostics would preserve it.
Audit boundary
The broader Desktop E2E audit found no other confirmed obsolete test. The streaming quote
fixmestill reproduced once in an 8-run, 4-worker probe, and the[hidden]override remains necessary because Astryx still uses a zero-specificity:where([hidden])reset.Verification
npm --workspace @maka/desktop run e2e -- e2e/sidebar-geometry.spec.ts --workers=1— full Desktop build passed; retained footer test passed.npm --workspace @maka/desktop run typecheck— passed.npx knip --workspace apps/desktop— passed.git diff --check— passed.AI use
Tool(s) and scope: OpenAI Codex traced dependency and test history, audited adjacent E2E and compatibility rules, removed confirmed obsolete paths, ran verification, and prepared this pull request.
Checklist
Does this PR entail a change in behavior?
中文
摘要
删除三处已由当前 Astryx 0.5.2 依赖承担的兼容规则:
Fixes #4622
根因
依赖升级后没有及时卸载 Maka 的临时兼容规则。resize E2E 新增时,锁定的 Astryx 已包含并测试该 hit-area 修复,因此这条测试只是通过两次 Electron 合成拖动重复验证上游行为。反向拖动 flake 暴露的是过期的责任边界;继续增加时序处理或诊断只会将它固化。
审计边界
更广的 Desktop E2E 审计没有发现其他已确认过时的测试。streaming quote
fixme在 4 worker、8 次 probe 中仍复现 1 次;[hidden]override 也仍有必要,因为 Astryx 当前仍使用零优先级的:where([hidden])reset。验证
npm --workspace @maka/desktop run e2e -- e2e/sidebar-geometry.spec.ts --workers=1— Desktop 完整构建通过,保留的 footer 测试通过。npm --workspace @maka/desktop run typecheck— 通过。npx knip --workspace apps/desktop— 通过。git diff --check— 通过。AI 使用
工具及范围:OpenAI Codex 追溯了依赖和测试历史,审计了相邻 E2E 和兼容规则,删除已确认过时的路径,完成验证并准备本 PR。
检查清单
本 PR 是否改变行为?