fix(i18n): require an explicit locale on presentation helpers - #4640
Open
orangeCatDeveloper wants to merge 1 commit into
Open
fix(i18n): require an explicit locale on presentation helpers#4640orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
A `'zh'` default let any caller that forgot the locale render Chinese to English users without a type error. Generated-by: Claude Code
orangeCatDeveloper
marked this pull request as ready for review
September 3, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Presentation helpers across desktop renderer,
@maka/core, and@maka/uidefaulted theirlocaleparameter to'zh', so a caller that forgot to pass it rendered Chinese to English users with no type error. This PR removes every such default (24 helpers, 23 files) so the locale is a required argument. No production caller relied on a default — every one already passed the locale it had in scope — so the runtime behavior is unchanged; only the type-level guarantee is new. Tests that leaned on the default now pass'zh'explicitly, and each touched helper gained one'en'assertion so the English path is proven rather than assumed.The six
@maka/uistreaming helpers with the same defect are fixed in #4524 and are not touched here; the two OAuth result helpers are fixed in #4551.Refs #2672
Verification
AI use
Select exactly one:
Tool(s) and scope: Claude Code — implementation, tests, and this description, under the contributor's direction; the commit carries a
Generated-by: Claude Codetrailer.Checklist