fix(desktop): persist workbar collapse per session

[DaBestCode]

Summary

Fixes #4693

Opening the right workbar in conversation A currently opens it for a new conversation B. Store collapse state by session in the layout reducer so B starts collapsed and returning to A restores its preference, including after renderer reload. Bind the owner before commit so an open requested during activation is not overwritten.

This chooses persistent per-session visibility, while keeping panel topology and dimensions global. The old global maka-session-workbar-collapsed-v1 preference has no session owner and is retired in favor of v2; sessions default to collapsed once on upgrade. Please review that persistence/topology split and migration behavior against the decision requested in the issue.

Prune deleted entries only after the catalog has a committed snapshot. The catalog selector distinguishes “not loaded” from “confirmed empty,” preventing startup from deleting saved preferences.

Verification

• New Electron regression fails against unchanged baseline b0255edcb35588b2f24efd386447d9a494c1e395 on Linux ARM64: B's panel is visible when it should be hidden.
• Fixed macOS ARM64 build: the requested A → B → A plus reload E2E passes; the full file has 9 tests, including A open → B collapsed → A open → reload → A open/B collapsed.
• Compiled workbar model/controller tests: 27 passed, covering persistence, old-key retirement, catalog readiness, deleted-session cleanup, malformed storage and activation-commit opening under StrictMode.
• npm run lint, npm run format:check, npm run build, npm run typecheck, both Desktop/UI knip checks, Desktop architecture validation (including 101 checker tests), and git diff --check passed.
• Full Workbar E2E run: 8 passed; one pre-existing narrow-layout test timed out waiting for its fake-backend response before reaching any Workbar assertion, then passed in isolation (1/1).
• Full repository test suite and the final patch on Windows/Linux were not run. Persistence was checked through storage round-trip and renderer reload, not an OS reboot.

Before: unchanged Linux ARM64 baseline, where B inherits A's expanded panel. The fixture image lacks CJK fonts, affecting labels only.

After: fixed macOS ARM64 build, where B stays collapsed after navigating back and reloading.

AI use

• No generative tool made a substantive contribution
• Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with repository/issue investigation, implementation, regression tests, verification, and this PR description. The commit includes Generated-by: OpenAI Codex. Human review remains required.

Checklist

• Tests cover the change and fail without it
• Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

• Yes — described under Summary above
• No

[Astro-Han]

Thanks for addressing the collapse state leaking between sessions. Please rebase onto current main now that #4789 has merged, and update the conflicting Workbar E2E to use its new open/close menu.

Keep the session-specific collapse preference and catalog-hydration guard, and verify A → B → A plus reload. Please also retain main's 340px panel minimum. #4692 touches the same controller, but I don't see a reason to make it a prerequisite.

AI-assisted review with Codex.

[DaBestCode]

Rebased onto current main after #4789 and force-pushed ee5dec6. I resolved the Workbar E2E against the new face menu: the regression opens a face from the launcher, opens another through the shared open/close menu, then verifies A → B → A and reload. Main's 340px minimum remains unchanged. Verification: 27/27 focused model/controller tests passed; the requested E2E passed; full build, typecheck, Biome, diff check, and Desktop architecture validation passed. In the 9-test Workbar E2E file, 8 passed and the existing narrow-layout test timed out before reaching a Workbar assertion, then passed when rerun alone.

[hqhq1025]

Reviewed exact head ee5dec66984afa985c1efc1fff5d2bd40b52b92c.

This change moves right-workbar visibility into a per-Session map while keeping topology and dimensions global. I found one P2: cleanup of a previous Session's final dynamic tab can overwrite the newly active Session's saved expanded state. The new navigation/reload regression passes, but it retains static tabs and does not exercise this cleanup path.

Validation passed for the focused controller/model suite (27/27), the targeted Electron journey (1/1), Desktop build and typecheck, renderer architecture (101/101), repository lint and format, changed-file Biome, ASF headers, diff checks, and a clean merge against current main (7370f07a94cf8a553bc9cf97f09048e9fdf25e14). GitHub exposes no hosted checks for this head.

Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.

[hqhq1025]

[P2] Preserve the newly active Session's visibility during stale-tab cleanup

After activate-session binds Session B, the layout effects in use-workbar-controller.ts:522-578 remove Terminal and Side Chat tabs owned by Session A. If that stale tab is the last right-side tab, the close branch above sets rightCollapsed = true, and this call records that value under the current owner, B. On this exact head I reproduced the production controller path with B saved expanded, A owning the sole Terminal, then switching to B: cleanup removed A's tab and changed B from expanded to collapsed. The visibility effect then persists the overwritten map. Please keep cleanup closes from mutating the newly active Session's visibility (or target the old owner explicitly), and add a regression for the dynamic-only A → previously-expanded B path.

[DaBestCode]

Fixed in ac3b3a7. Stale Terminal and Side Chat cleanup now dispatches a topology-only remove-stale transition, so removing A's final right-side dynamic tab cannot record a collapse under active Session B. User-triggered closes still collapse an emptied right panel, and bottom-panel cleanup keeps its previous behavior. Added the requested production-controller regression: B is saved expanded, A opens the sole Terminal, then switching to B removes A's tab while B remains expanded. Verification: focused model/controller suite 28/28; A → B → A plus reload Electron journey 1/1; Desktop main/renderer builds, typecheck, renderer architecture 101/101, repository lint/format, ASF headers, Biome, and diff checks pass.

[hqhq1025]

Reviewed exact head ac3b3a79c7c763f0a92cac52bd7ca37143a72499. I did not find a remaining correctness issue in this head.

The follow-up fixes the previously reported cross-Session visibility overwrite. Stale Terminal cleanup now uses the visibility-preserving path at use-workbar-controller.ts:539-546, stale Side Chat cleanup does the same at use-workbar-controller.ts:559-575, and workbar-layout.ts:249-276 removes those tabs without recording an empty right panel as collapsed for the newly active Session. Ordinary user closes still use the normal close action, while stale bottom-panel cleanup retains the prior behavior of closing an empty bottom panel.

Validation completed:

• Clean install and full build:test passed.
• Full Desktop test suite: 2218 passed, 0 failed.
• Focused Workbar controller/model suite: 28 passed, including the dynamic-only stale Terminal regression.
• The A → B → A plus reload Electron journey passed on both the PR head and a synthetic merge with current main (411512bd9cb698f668eccbae35adf41e71d7cf68).
• Desktop build and typecheck, renderer architecture (101/101), repository lint/format, ASF headers, and diff checks passed.
• GitHub currently exposes no hosted checks for this head.

I did not run the Electron journey on native macOS or Windows.

Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.