Skip to content

docs(architecture): audit Model access slice under #3522 #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bytelazy wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

docs(architecture): audit Model access slice under #3522 #4711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/model-metadata-firstscreen-optimization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
under the License.
-->

> **Audit note (2026-09-04, #4711):** This optimization is **partially** implemented. Verified done: `OnboardingHero` no longer imports `RECOMMENDED_PROVIDER_TYPES` at runtime (it uses a local `FIRST_RUN_PROVIDER_TYPES` constant; `onboarding-hero.tsx:27` is `import type` only). Not done: a static import chain still reaches `provider-registry` from the first screen — `main.tsx` → `app.tsx` → `app-shell.tsx` → `app-shell-overlays.tsx` → `app-shell-command-actions.ts` → `command-palette-commands.ts` → `isRetiredProvider` (a value import) → `providerDefaultsOf` → `PROVIDER_REGISTRY`, which is constructed from the generated models.dev tables (`provider-registry.ts:24`). Tree-shaking cannot drop it: `PROVIDER_REGISTRY` is a used constant. The document is retained as a live design record until that chain is broken (e.g. by extracting the small retirement predicate out of `provider-registry`).

# perf(desktop): remove models.dev metadata from the renderer startup path

<details open>
Expand Down