Skip to content

fix(storage): stream large Codex rollout imports - #4715

Open
liuxiaocs7 wants to merge 1 commit into
apache:mainfrom
liuxiaocs7:liuxiaocs7/fix-storage-large-codex-rollouts-listed-for-impo
Open

fix(storage): stream large Codex rollout imports#4715
liuxiaocs7 wants to merge 1 commit into
apache:mainfrom
liuxiaocs7:liuxiaocs7/fix-storage-large-codex-rollouts-listed-for-impo

Conversation

@liuxiaocs7

Copy link
Copy Markdown
Member

Summary

Stream Codex rollout JSONL from a fixed file snapshot instead of reading the complete file into one string. The importer now supports valid rollouts beyond the previous 64 MiB cap while bounding source bytes, individual records, converted bytes, and message count.

Source read or conversion failures are reported as a definite source_unreadable result, while failures after persistence begins remain commit_outcome_unknown. Desktop shows the source-specific failure without starting uncertain-commit recovery.

Fixes #4642

Verification

  • npm run build:test
  • node --test packages/storage/dist/__tests__/codex-session-adapter.test.js packages/runtime-host/dist/__tests__/external-session-coordinator.test.js packages/runtime-host/dist/__tests__/protocol.test.js apps/desktop/dist/main/__tests__/runtime-host-external-sessions-ipc-main.test.js apps/desktop/dist/main/__tests__/import-tasks-settings-page.test.js — 142 passed
  • npm run lint
  • npm run format:check
  • npm run typecheck

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with diagnosis, implementation, tests, resource-bound ablation experiments, and PR preparation. The commit retains its Generated-by: OpenAI Codex trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/L Under 1000 readable lines label Sep 4, 2026
@liuxiaocs7
liuxiaocs7 force-pushed the liuxiaocs7/fix-storage-large-codex-rollouts-listed-for-impo branch from d40e139 to d6380f6 Compare September 4, 2026 03:16
@liuxiaocs7
liuxiaocs7 force-pushed the liuxiaocs7/fix-storage-large-codex-rollouts-listed-for-impo branch from 30863ff to 361c11f Compare September 4, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/L Under 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): large Codex rollouts listed for import fail at the 64 MiB read cap

1 participant