feat(desktop): expose bot onboarding retry health - #4746
Conversation
3a37a66 to
20a2442
Compare
hqhq1025
left a comment
There was a problem hiding this comment.
I reviewed exact head 0c2008256f8dcf94a26435e951610f0c0898d481.
This change adds a finite, redacted retry-health projection and localized onboarding status, with focused lifecycle and Electron coverage. I found one P2 state-machine issue in the post-confirmation error path, so I do not recommend merging this head yet.
Validation included a clean install, build:test, Desktop typecheck/build, Core (825/825) and Desktop (2165/2165) dist suites, focused onboarding/redaction tests, renderer architecture (98/98), both affected Electron journeys, lint, format, Biome, ASF headers, diff check, hosted test, and a clean patch-preserving merge onto current main (7743890729b26a7e95f653af8b93ccbe42ad480f). I did not exercise live provider APIs or native macOS/Windows UI behavior.
Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.
0c20082 to
8cbdb12
Compare
|
@hqhq1025 Addressed the P2 from your review comment in commit The retry classifier is now enabled only after the provider poll promise rejects. Once the provider returns Targeted diff check passed; the branch was rebased onto current |
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
5990e5b to
8f43713
Compare
Summary
Fixes #4745
Verification
npm run lint.npm run format:check.npx knip --workspace apps/desktop.npm run check:asf-headers.git diff --check.Visual evidence
Built and launched current head
3a37a66f3in a visible local Electron App. The real QR onboarding modal kept the QR available while showing only the bounded retry category, consecutive count, and retry delay. This is a direct App capture, not a mockup or generated image.The Electron test also asserts that fixture provider details do not appear in the renderer.
Review focus
The existing poll loop remains the only retry authority.
retryHealthcontains only a finite category, consecutive count, and retry timing; raw provider errors and credentials remain main-process-only.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the bounded Core/Desktop contract, main-process projection, localized UI state, deterministic lifecycle/redaction coverage, and E2E visual fixture. The human contributor remains responsible for review and submission.
Checklist
Does this PR entail a change in behavior?