Document deprecation rationale for executeChangeLogCommand overloads#1350
Document deprecation rationale for executeChangeLogCommand overloads#1350anukalp2804 wants to merge 1 commit intoapache:masterfrom
Conversation
|
This is not exactly true - we have in fact impl for this for git provider |
8ed212b to
962789e
Compare
Thanks for the clarification. I’ve updated the Javadoc to reflect that some providers (such as Git) still implement this API while clarifying that it remains part of the legacy path and is primarily retained for backward compatibility. |
There was a problem hiding this comment.
Pull request overview
This PR adds deprecation documentation to three overloaded executeChangeLogCommand methods in AbstractChangeLogCommand. The documentation explains that these methods are part of a legacy API retained for backward compatibility with existing SCM provider implementations.
- Adds detailed JavaDoc explaining the rationale for deprecating legacy changelog command execution methods
- Clarifies that some providers (e.g., Git) still use the original abstract method
- Notes that the two concrete overloads often throw
ScmExceptionand are not widely supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Just checking in on this PR. It has been idle for a while and is still awaiting workflow approval and review. |
|
Hi @slachiewicz , Just a gentle follow-up on this PR. Thanks for your time. |
Fixes #1344
Documents the rationale for the deprecation of the legacy
executeChangeLogCommand methods in AbstractChangeLogCommand and clarifies
that they are retained only for backward compatibility with existing SCM
provider implementations.
No functional behavior is changed. These methods remain deprecated and are
not recommended for use by new implementations.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.