Skip to content

First version of semantic highlight support for both the LSP client and Java LSP server. - #2617

Merged
jlahoda merged 15 commits into
apache:masterfrom
jlahoda:lsp-semantic-highlight
Jan 14, 2022
Merged

First version of semantic highlight support for both the LSP client and Java LSP server.#2617
jlahoda merged 15 commits into
apache:masterfrom
jlahoda:lsp-semantic-highlight

Conversation

@jlahoda

@jlahoda jlahoda commented Dec 29, 2020

Copy link
Copy Markdown
Contributor

This is a new feature in the protocol version 3.16.0.

@jlahoda jlahoda added the LSP [ci] enable Language Server Protocol tests label Dec 29, 2020
@jlahoda
jlahoda requested a review from dbalek November 23, 2021 21:25

@dbalek dbalek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

.setOutput(io.second())
.wrapMessages(processor)
// .traceMessages(new java.io.PrintWriter(System.err))
.configureGson(gb -> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configureGson is already called couple of lines above - registrations should be merged.

@Chris2011

Copy link
Copy Markdown
Contributor

Could this be already ready for NB 13?

@jlahoda jlahoda added this to the NB13 milestone Jan 13, 2022
@jlahoda
jlahoda merged commit d2ae8ba into apache:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LSP [ci] enable Language Server Protocol tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants