Skip to content

[NETBEANS-5565] Disable running LSP servers for VCS diffs. - #2876

Merged
neilcsmith-net merged 2 commits into
apache:masterfrom
jlahoda:NETBEANS-5565
Jan 17, 2022
Merged

[NETBEANS-5565] Disable running LSP servers for VCS diffs.#2876
neilcsmith-net merged 2 commits into
apache:masterfrom
jlahoda:NETBEANS-5565

Conversation

@jlahoda

@jlahoda jlahoda commented Apr 10, 2021

Copy link
Copy Markdown
Contributor

Seems sensible to not run the LSP servers for diff windows. There does not seem to be a very clean way, so just looking at the directory names.

@jlahoda jlahoda added the LSP [ci] enable Language Server Protocol tests label Apr 10, 2021
@jlahoda
jlahoda requested a review from JaroslavTulach April 10, 2021 21:57
@Chris2011

Copy link
Copy Markdown
Contributor

So that means, that we can't have code completion in the working tree area where I can still change the code? It would be nice, if we can have this soon in NetBeans, unfortunately it is not part of 12.4.

@ebarboni

ebarboni commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

can we make this for 12.5 @jlahoda ?

@Chris2011

Copy link
Copy Markdown
Contributor

What is missing here? I think if there are no concerns, we can merge this. Also we should think about critical or blocker issues to prioritze them. Is it still time to get it into 12.5?

@Chris2011

Copy link
Copy Markdown
Contributor

Also I would like to get my question answered that I mentioned:

So that means, that we can't have code completion in the working tree area where I can still change the code?

If it was not clear, I'm asking for the diff window. What happens with the code completion inside of such diff window, if the server is not running? I mean it is not about having the language server, for the TypeScript, it is just that the process where created again and again.

@matthiasblaesing

Copy link
Copy Markdown
Contributor

@Chris2011 12.5 was released about a day ago, so no, this definitely won't make it into 12.5.

@ebarboni ebarboni added this to the 12.6 milestone Sep 22, 2021
@neilcsmith-net neilcsmith-net modified the milestones: 12.6, NB13 Oct 22, 2021
@Chris2011

Copy link
Copy Markdown
Contributor

For me the code looks good, I also checked it months ago. If this is the way we go with just checking "vcs-" than it is ok. I just thought this is just a workaround. But I'm not into the API.

@neilcsmith-net

Copy link
Copy Markdown
Member

@Chris2011 OK! Just pushing PRs back to NB14, but this looks minimally intrusive but useful, so merging. Please check when 13-rc1 is available.

@neilcsmith-net
neilcsmith-net merged commit a764e99 into apache:master Jan 17, 2022
@Chris2011

Copy link
Copy Markdown
Contributor

Great thx :). Will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LSP [ci] enable Language Server Protocol tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants