fixed class modifier auto completion for sealed classes.

[mbien]

minor bugfix:
contains(String) was called on a Set containing Modifier enums - which is always false.

Although we can't use the two sealed enums directly since they are JDK 17+, they can be still queried via a little utility method.

Added auto completion tests for sealed class declaration.

[mbien]

@Akshay-Gupta-Oracle @matthiasblaesing @jlahoda anyone interested to review this?

Had time to add some tests now. i give this a 75% chance that I did put the golden files into the wrong folder (again).

[matthiasblaesing]

I left a single inline comment - apart from that, this looks sane to me. It would be great if the other reviewers could also have a look. I'll restart the tests.

[matthiasblaesing]

Ran tests locally and worked as expected. @mbien if in one week no second review comes in, please ping me and I'll merge.

[mbien]

@matthiasblaesing thanks. will do. Would be nice if @jlahoda could take a look. Because i have the suspicion that the golden files still have to be in the 1.8 folder but i am not 100% certain. It depends on whether NB 13 having JDK 17 compatible nb-javac installed by default or not I guess.

[jlahoda]

@matthiasblaesing thanks. will do. Would be nice if @jlahoda could take a look. Because i have the suspicion that the golden files still have to be in the 1.8 folder but i am not 100% certain. It depends on whether NB 13 having JDK 17 compatible nb-javac installed by default or not I guess.

Yes, I think it would be preferrable to have the in the 1.8 folder. The folders represent the runtime platform, and are unrelated to the source level supported by the Java parser. (If the selected Java parser does not support the source level, the test will be skipped anyway, but I think we are heading to a place where this won't happen normally.) I realize this is fairly confusing.

Otherwise looks good!

Thanks!

[mbien]

@jlahoda thanks jan! Moved them to the 1.8 folder.

[jlahoda]

Looks good.