[NETBEANS-5846] Minimal support of java-platfom Gradle projects. - #3293
Conversation
|
Sorry, missed this was opened against delivery as missing a milestone. Intended for 12.6? I've only given it a glance. If you think it needs to go in RC2, please feel free to merge before tomorrow. |
2bc206e to
ff24738
Compare
| def name = it.name | ||
| def version = it.version != null ? ':' + it.version : '' | ||
| def id = group + ':' + name + version; | ||
| componentIds.add(id) |
There was a problem hiding this comment.
is it OK to pass on malformed component IDs, e.g. no name or no group ?
There was a problem hiding this comment.
No group, no version names are valid.
|
|
||
| private boolean needsResolve() { | ||
| GradleBaseProject gbp = GradleBaseProject.get(project); | ||
| return !gbp.isResolved() && !gbp.hasPlugins("java-platform"); //NOI18N |
There was a problem hiding this comment.
Hm, this means that if a configuration is NOT resolved , but the project does use java-platform plugin - the project as a whole ceases needing to be resolved ?
There was a problem hiding this comment.
Well it is about the warning badge and the tooltip. We put warning the configuration is not resolved in general.
However java-platform project can't be resolved by definition. So we do not place warning badge and unresolved config hint on the node.
neilcsmith-net
added
the
do not merge
|
I'm going to sync and trigger RC2 now, so given review in progress, please don't merge now. We'll likely have an RC3 so we can merge for that once review process complete. Thanks! |
|
@sdedic @lkishalmi what's the status of review here now? Thanks! |
|
Let's have this on early 13.0 instead. I'm going to rebase this on master. |
lkishalmi
removed
the
do not merge
|
I'm merging this to the master, let's see how this works out |
4 participants
Slightly more than just disabling the warnings on java-platform Gradle projects.
Did some testing on the weekend including the test why api and some other configurations are not showing up in the UI.
Those are the configurations the users often use. It turned out that Gradle marks those configurations as non-resolvabe (canBeResolved property is false).
So I made some adjustments to let them displayed.
Before:
After:
