[NETBEANS-3362] Show inherited members on the navigator pane - #3296
Conversation
junichi11
commented
Nov 2, 2021
junichi11
commented
- https://issues.apache.org/jira/browse/NETBEANS-3362
- Introduce StructureItem.InheritedItem interface
- Show inherited members on the navigator pane
junichi11
added
API Change
|
@sdedic Could you please take a look at the CSL part (the first commit)? |
1c912ab to
aee7893
Compare
|
Umm, there are problems with other features(overriding method, bread crumb). Will investigate it... |
aee7893 to
7f9aced
Compare
7f9aced to
28c4692
Compare
| while (!todo.isEmpty()) { | ||
| StructureItem i = todo.remove(0); | ||
| if (i instanceof StructureItem.InheritedItem | ||
| && ((StructureItem.InheritedItem) i).isInherited()) { |
There was a problem hiding this comment.
Rather than spreading these instance checks all over the place, there could be a helper method:
public static boolean isInherited(StructureItem i) {
}it could actually be in StructureItem interface itself now, when it is possible to have static methods in interfaces.
There was a problem hiding this comment.
Thank you for your review! Will do that.
There was a problem hiding this comment.
JaroslavTulach
left a comment
JaroslavTulach
left a comment
There was a problem hiding this comment.
Fair use of extending interfaces.
|
Sigh. I had a PR review pending, but unpublished. @JaroslavTulach review's notification made me look & discover the draft. Sorry for the delay :( |
|
@sdedic Don't worry about it :) I guessed you are so busy. Thank you for your review! |
28c4692 to
413de55
Compare
|
@JaroslavTulach @sdedic I've fixed the points that were pointed out. Please let me know if there are any problems. Thanks! |
|
@tmysik Could you please review the PHP part? |
tmysik
left a comment
tmysik
left a comment
There was a problem hiding this comment.
The PHP part looks OK to me. Thanks a lot for your great work, @junichi11!
|
@tmysik Thank you for your review! |
- https://issues.apache.org/jira/browse/NETBEANS-3362 - Add the new interface(`StructureItem.InheritedItem`) to show inherited items on the navigator pane. - Add `StructureItem.isInherited()` - See also http://wiki.apidesign.org/wiki/ExtendingInterfaces
413de55 to
89b415b
Compare
| * @return the declaring element handle of the inherited item | ||
| */ | ||
| @NonNull | ||
| ElementHandle getDeclaringElement(); |
There was a problem hiding this comment.
Generally, I suppose this doesn't return null.
|
Will merge this. Thanks! |
4 participants
