Skip to content

Allow VSCode users to choose 'local' - e.g. per workspace userdir #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaroslavTulach merged 1 commit into from
Nov 8, 2021
Merged

Allow VSCode users to choose 'local' - e.g. per workspace userdir #3308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions java/java.lsp.server/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@
"default": false,
"description": "Enables verbose messages from the Apache NetBeans Language Server"
},
"netbeans.userdir": {
"description": "Keep settings and caches as 'global' or 'local' per workspace?",
"type": "string",
"enum": [
"global",
"local"
],
"enumDescriptions": [
"Share data between all workspaces (more effective)",
"Each workspace has its own data (more isolated)"
],
"default": "global"
},
"netbeans.conflict.check": {
"type": "boolean",
"default": true,
Expand Down
20 changes: 18 additions & 2 deletions java/java.lsp.server/vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,11 +432,27 @@ function doActivateWithJDK(specifiedJDK: string | null, context: ExtensionContex
}, time);
};

const beVerbose : boolean = workspace.getConfiguration('netbeans').get('verbose', false);
const netbeansConfig = workspace.getConfiguration('netbeans');
const beVerbose : boolean = netbeansConfig.get('verbose', false);
let userdir = netbeansConfig.get('userdir', 'global');
switch (userdir) {
case 'local':
if (context.storagePath) {
userdir = context.storagePath;
break;
}
// fallthru
case 'global':
userdir = context.globalStoragePath;
break;
default:
// assume storage is path on disk
}

let info = {
clusters : findClusters(context.extensionPath),
extensionPath: context.extensionPath,
storagePath : context.globalStoragePath,
storagePath : userdir,
jdkHome : specifiedJDK,
verbose: beVerbose
};
Expand Down