Small improvement on GitBranchHash which is able to get at least the hash of a detached HEAD - #3334
Merged
Merged
Conversation
…hash of a detached HEAD
neilcsmith-net
approved these changes
Nov 26, 2021
neilcsmith-net
left a comment
neilcsmith-net
left a comment
Member
There was a problem hiding this comment.
Looks good. Always meant to go back and look at this. Ideally we'd pick up the branch from the hash - at least all release hashes are only on one branch - or maybe get the branch from the json file if any matching hash. Would make building from tags work correctly.
| String revline = revlines.get(0); | ||
| if(revline.length()>=12){ | ||
| hash = revline.trim(); | ||
| if (!line.contains(":") && (line.length() == 40)) { |
Member
There was a problem hiding this comment.
Not sure if this should be >= 40 and also trimmed? I have also no idea if >= 12 was just copying from HgID or necessary. 🤷
Contributor
Author
There was a problem hiding this comment.
I do not know that either. Just made some adjustments to work with a detached head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from an unmerged commit #3151.