[NETBEANS-5599] PHP 8.1 Support: Never type - #3340
Merged
Merged
Conversation
- Use `HintErrorRule` instead of `UnhandledError` - Add unit tests
https://issues.apache.org/jira/browse/NETBEANS-5599 RFC: https://wiki.php.net/rfc/noreturn_type - Add `hasNeverType()` to `PhpVersion` - Fix the lexer - Mark as an error if something is returned when the return type is `never` - Mark as an error if `never` is used at incorrect places (e.g. private never $propertyType) - Add unit tests for the lexer and hints
https://issues.apache.org/jira/browse/NETBEANS-5599 RFC: https://wiki.php.net/rfc/noreturn_type - Fix the code completion - Add and fix unit tests for the code completion
Member
Author
|
CI failed: see #3339 |
Member
Author
|
@tmysik Could you please have a look at this? If there is no problem, let's merge it. Thanks. |
tmysik
approved these changes
Nov 30, 2021
tmysik
left a comment
tmysik
left a comment
Member
There was a problem hiding this comment.
Looks good to me, many unit tests. Thanks for your great work!
Member
Author
|
Thank you for your review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/NETBEANS-5599
RFC: https://wiki.php.net/rfc/noreturn_type
(Part 1)
hasNeverType()toPhpVersionneverneveris used at incorrect places (e.g. private never $propertyType)(Part 2)
Screenshot