Skip to content

Maven should not filter out non-jrt URLs from Java platform modular BCP. - #8538

Merged
mbien merged 1 commit into
apache:masterfrom
lahodaj:maven-module-boot-dont-limit-jrtfs
Jul 15, 2026
Merged

Maven should not filter out non-jrt URLs from Java platform modular BCP.#8538
mbien merged 1 commit into
apache:masterfrom
lahodaj:maven-module-boot-dont-limit-jrtfs

Conversation

@lahodaj

@lahodaj lahodaj commented May 27, 2025

Copy link
Copy Markdown
Contributor

When computing module boot path, the Maven provider filters out URLs that are not nbjrt URLs. That does not make much sense to me, and it does not work for exploded JDK builds (which have classfiles in directories on the filesystem, not in the JRT file system).

I propose to simply use whatever bootstrap libraries the platform provides, and not filter them.

@lahodaj lahodaj added this to the NB27 milestone May 27, 2025
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label May 27, 2025
@mbien mbien added Maven [ci] enable "build tools" tests Platform [ci] enable platform tests (platform/*) labels May 27, 2025
@mbien

mbien commented May 27, 2025

Copy link
Copy Markdown
Member

adding platform and maven tests and restarting CI

@apache apache locked and limited conversation to collaborators May 27, 2025
@apache apache unlocked this conversation May 27, 2025
@mbien mbien removed the Platform [ci] enable platform tests (platform/*) label May 28, 2025
@mbien

mbien commented May 28, 2025

Copy link
Copy Markdown
Member

how do you add the exploded folder as JDK? I believe the only thing which worked for me in past was to add the image output in jdk/build/linux-x86_64-server-release/images/jdk

@ebarboni ebarboni modified the milestones: NB27, NB28 Jul 23, 2025
@ebarboni ebarboni modified the milestones: NB28, NB29 Oct 15, 2025
@ebarboni ebarboni modified the milestones: NB29, NB30 Jan 22, 2026
@ebarboni ebarboni modified the milestones: NB30, NB31 Apr 15, 2026
@lahodaj

lahodaj commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

how do you add the exploded folder as JDK? I believe the only thing which worked for me in past was to add the image output in jdk/build/linux-x86_64-server-release/images/jdk

Sorry, I missed the question. Adding ${build-dir}/jdk should work, and that's the exploded build. I.e. in your case jdk/build/linux-x86_64-server-release/jdk.

@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jul 13, 2026
@mbien

mbien commented Jul 13, 2026

Copy link
Copy Markdown
Member

@lahodaj we could merge this too. Please rebase till Wednesday.

@lahodaj
lahodaj force-pushed the maven-module-boot-dont-limit-jrtfs branch from 9d91973 to bb01f5d Compare July 14, 2026 12:42
@lahodaj

lahodaj commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

OK to merge?

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try. Its small so it would be easy to revert if something shows up during RC.

@mbien
mbien merged commit 1b19609 into apache:master Jul 15, 2026
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants